-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge feature/vector tiles branch to master #73872
Merged
Merged
Changes from 20 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
e0e8d6e
initial skeleton of vector tiles prototype implementation (#69338)
iverase bf2b209
Vector Tiles: Start refactoring rest layer (#71080)
imotov e3acfc6
Vector Tiles: continue REST layer refactoring (#71259)
imotov 14826ec
simplify mvt end point (#71548)
iverase 7b6f3da
Vector Tiles: add a more generic way of building meta layer (#71804)
imotov 9a86dde
Merge branch 'master' into feature/vector-tiles
iverase d6cfec0
Add value ranges for GeoTile aggregation metrics metrics in the meta …
iverase c4f919d
Vector Tiles: add support for array serialization in meta layer (#72136)
imotov cf360ce
Merge branch 'master' into feature/vector-tiles
iverase bfbd991
Merge branch 'master' into feature/vector-tiles
iverase 2fe2ee7
Vector Tiles: Add support for feature flag (#72657)
imotov 4528e78
Merge branch 'master' into feature/vector-tiles
iverase 18e30d9
Merge branch 'master' into feature/vector-tiles
iverase 09056ed
Merge branch 'master' into feature/vector-tiles
iverase 929ff3c
Merge branch 'master' into feature/vector-tiles
iverase 2b27561
Move vector tile implementation to its own module (#73562)
iverase 2afb4ac
Merge branch 'master' into feature/vector-tiles
iverase 9cbc5f7
Merge branch 'master' into feature/vector-tiles
iverase f364883
Fix extra line in build.gradle from spatial module (#73816)
iverase ad11159
Merge remote-tracking branch 'elastic/master' into feature/vector-tiles
imotov 88a43f9
Update x-pack/plugin/vector-tile/src/main/java/org/elasticsearch/xpac…
imotov 106a965
Update x-pack/plugin/vector-tile/src/main/java/org/elasticsearch/xpac…
imotov 6a8f8f3
Merge remote-tracking branch 'elastic/master' into feature/vector-tiles
imotov 19ade1e
Fix vector tile plugin after master merge
imotov 29f939a
Address review comments
imotov 8ae6cf4
Fix spotless issues
imotov 82ae674
Merge branch 'master' into feature/vector-tiles
elasticmachine File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,69 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0 and the Server Side Public License, v 1; you may not use this file except | ||
* in compliance with, at your election, the Elastic License 2.0 or the Server | ||
* Side Public License, v 1. | ||
*/ | ||
|
||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0; you may not use this file except in compliance with the Elastic License | ||
* 2.0. | ||
*/ | ||
|
||
import org.elasticsearch.gradle.internal.info.BuildParams | ||
|
||
apply plugin: 'elasticsearch.internal-es-plugin' | ||
apply plugin: 'elasticsearch.java-rest-test' | ||
|
||
esplugin { | ||
name 'vector-tile' | ||
description 'A plugin for mapbox vector tile features' | ||
classname 'org.elasticsearch.xpack.vectortile.VectorTilePlugin' | ||
extendedPlugins = ['x-pack-core'] | ||
} | ||
|
||
dependencies { | ||
compileOnly project(path: xpackModule('core')) | ||
testImplementation(testArtifact(project(xpackModule('core')))) | ||
api "com.wdtinc:mapbox-vector-tile:3.1.0" | ||
api "com.google.protobuf:protobuf-java:3.14.0" | ||
javaRestTestImplementation("com.wdtinc:mapbox-vector-tile:3.1.0") | ||
javaRestTestImplementation("com.google.protobuf:protobuf-java:3.14.0") | ||
} | ||
|
||
testClusters.all { | ||
setting 'xpack.license.self_generated.type', 'trial' | ||
testDistribution = 'DEFAULT' | ||
setting 'xpack.security.enabled', 'false' | ||
if (BuildParams.isSnapshotBuild() == false) { | ||
systemProperty 'es.vector_tile_feature_flag_registered', 'true' | ||
} | ||
} | ||
|
||
tasks.named("test").configure { | ||
if (BuildParams.isSnapshotBuild() == false) { | ||
systemProperty 'es.vector_tile_feature_flag_registered', 'true' | ||
} | ||
} | ||
|
||
tasks.named("thirdPartyAudit").configure { | ||
ignoreViolations( | ||
// uses internal java api: sun.misc.Unsafe | ||
'com.google.protobuf.UnsafeUtil', | ||
'com.google.protobuf.MessageSchema', | ||
'com.google.protobuf.UnsafeUtil$1', | ||
'com.google.protobuf.UnsafeUtil$Android32MemoryAccessor', | ||
'com.google.protobuf.UnsafeUtil$Android64MemoryAccessor', | ||
'com.google.protobuf.UnsafeUtil$JvmMemoryAccessor', | ||
'com.google.protobuf.UnsafeUtil$MemoryAccessor' | ||
) | ||
|
||
ignoreMissingClasses( | ||
'org.slf4j.Logger', | ||
'org.slf4j.LoggerFactory' | ||
) | ||
} | ||
|
1 change: 1 addition & 0 deletions
1
x-pack/plugin/vector-tile/licenses/mapbox-vector-tile-3.1.0.jar.sha1
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
06c4432c7885a3938571a57e73cc1444d7a39f12 |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to care about the case when a field exists under two different paths in the map, so that one doesn't override the other? Let's document the behavior if we think it's acceptable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think for our purpose overriding is acceptable. We can fix check for it and throw an exception if needed. I will add javadoc with the explanation of the limitations for now.