Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EQL: Fix the bwc serialization tests #69534

Merged
merged 1 commit into from
Feb 24, 2021

Conversation

astefan
Copy link
Contributor

@astefan astefan commented Feb 24, 2021

This is a follow up to #69447 and #68962.

@astefan astefan added :Analytics/EQL EQL querying >bug >test Issues or PRs that are addressing/adding tests v7.13.0 v8.0.0 labels Feb 24, 2021
@elasticmachine elasticmachine added the Team:QL (Deprecated) Meta label for query languages team label Feb 24, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-ql (Team:QL)

Copy link
Contributor

@matriv matriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@bpintea bpintea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
The added new instances could optionally also be made static. Up to you.

@astefan astefan merged commit df74efb into elastic:master Feb 24, 2021
@astefan astefan deleted the eql_serialization_test_fix branch February 24, 2021 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/EQL EQL querying >bug Team:QL (Deprecated) Meta label for query languages team >test Issues or PRs that are addressing/adding tests v7.13.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants