Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a template parameter to override auto_create_index value #61858
Add a template parameter to override auto_create_index value #61858
Changes from 76 commits
ee50924
f62c83b
097d9f5
3bb580c
42cfc00
8c17371
9a1e10a
961cfcf
41fdcb3
2228033
b00297e
ad5021d
ad9e699
c42e3ce
6a689b2
f81a510
2d54d2c
85abcbc
eb299a0
a3e3691
9421140
ebb42d4
a93cfb2
bfe8c8c
2694fb2
5d5eeb4
39abb38
4b9034a
ce8c2ed
2e9a4c7
d5db431
1d07709
36b9ca8
93e2440
4a2e64c
82ad6e4
6022b3c
41b2fc6
6127caf
9d6b6cf
c0394e4
cbfbb98
383d6ff
61ab28e
6c4c817
ed692c7
e8617b6
4f051af
44d7d66
e145266
9e8221a
dd7a22f
cfca1e4
85c0b54
0204f0a
eae0eaa
d9aea1c
13ef3ab
4bdc322
c3d1981
ae05665
2cd82f2
8bf7976
b4cc55c
1545c0a
55172b6
9a9b96b
7db889c
70f758e
1376afd
dec6ea9
00b0bdf
473975c
f45ea30
0482f5c
421679d
6bd5456
0fd0f84
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe
distribution/archives/integ-test-zip
is a better place for this test class? Given that it doesn't extendHttpSmokeTestCase
and this test class doesn't seem to require to start a node with special settings or plugins.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm honestly not sure. I tried before to find out where is the "correct" place for REST tests, but couldn't get a clear answer. I think I'll leave this test alone and start an email thread about it. I feel that it ought to be easier to say where a REST test should live.