Expand max chain depth testing #61833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit extends the coverage around max chain depth in runtime fields. We test that direct references are not counted, that 5 references are allowed while 6 are not, and we test that the same error is returned no matter where the runtime field is used.
javanna
added
>test
|
Pinging @elastic/es-search (:Search/Search) |
javanna
commented
Sep 2, 2020
| body: | ||
| sort: loose_loop | ||
| --- | ||
| "loose loop - docvalue_fields": |
There was a problem hiding this comment.
I am aware that splitting tests like this will cause more setup / tear down, yet I think it makes the tests less descriptive and targeted each one at their own specific goal.
javanna
commented
Sep 2, 2020
| index: sensor | ||
| body: | ||
| sort: timestamp | ||
| docvalue_fields: [over_max_depth] |
There was a problem hiding this comment.
Note that there are no tests for queries, on purpose. They need to be fixed :)
There was a problem hiding this comment.
Yeah, I have this on my list but I keep getting distracted by shiny objects.
|
Lgtm
…On Wed, Sep 2, 2020, 04:06 Luca Cavanna ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In
x-pack/plugin/src/test/resources/rest-api-spec/test/runtime_fields/90_loops.yml
<#61833 (comment)>
:
> +"Max chain depth - sort":
+ - do:
+ catch: '/Field requires resolving too many dependent fields: over_max_depth -> over_max_depth_1 -> over_max_depth_2 -> over_max_depth_3 -> over_max_depth_4 -> over_max_depth_5/'
+ search:
+ index: sensor
+ body:
+ sort: over_max_depth
+---
+"Max chain depth - docvalue_fields":
+ - do:
+ catch: '/Field requires resolving too many dependent fields: over_max_depth -> over_max_depth_1 -> over_max_depth_2 -> over_max_depth_3 -> over_max_depth_4 -> over_max_depth_5/'
+ search:
+ index: sensor
+ body:
+ sort: timestamp
+ docvalue_fields: [over_max_depth]
Note that there are not tests for queries, on purpose. They need to be
fixed :)
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#61833 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABUXIUTJ33JTEXKGAYJUV3SDX4HRANCNFSM4QSWROPA>
.
|
nik9000
approved these changes
Sep 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit extends the coverage around max chain depth in runtime fields. We test that direct references are not counted, that 5 references are allowed while 6 are not, and we test that the same error is returned no matter where the runtime field is used.