Implement deprecation logging using log4j #61474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of elastic#46106. Simplify the implementation of deprecation logging by relying of log4j more completely, and implementing additional behaviour through custom appenders and filters.
pugnascotia
added
:Core/Infra/Core
|
Pinging @elastic/es-core-infra (:Core/Infra/Core) |
This was referenced Aug 24, 2020
pugnascotia
added a commit
to pugnascotia/elasticsearch
that referenced
this pull request
Aug 27, 2020
Backport of elastic#61474. Part of elastic#46106. Simplify the implementation of deprecation logging by relying of log4j more completely, and implementing additional behaviour through custom appenders and filters.
pugnascotia
added a commit
that referenced
this pull request
Aug 31, 2020
pugnascotia
added a commit
that referenced
this pull request
Sep 2, 2020
PR #61474 reworked deprecation logging to rely more heavily on log4j. Unfortunately, the changes required to log4j's configuration were not applied to the version we ship with the Docker image.
pugnascotia
added a commit
that referenced
this pull request
Sep 2, 2020
PR #61474 reworked deprecation logging to rely more heavily on log4j. Unfortunately, the changes required to log4j's configuration were not applied to the version we ship with the Docker image.
|
Note that these changes related to indexing the logs were removed from |
61 tasks
pgomulka
added a commit
to pgomulka/elasticsearch
that referenced
this pull request
Feb 18, 2021
The elastic#61474 changed the way we throttle deprecation logs, but missed a filter to plaintext deprecation logs closes elastic#69188
pgomulka
added a commit
that referenced
this pull request
Feb 23, 2021
pgomulka
added a commit
to pgomulka/elasticsearch
that referenced
this pull request
Feb 23, 2021
The elastic#61474 changed the way we throttle deprecation logs, but missed a filter to plaintext deprecation logs closes elastic#69188
pgomulka
added a commit
to pgomulka/elasticsearch
that referenced
this pull request
Feb 23, 2021
The elastic#61474 changed the way we throttle deprecation logs, but missed a filter to plaintext deprecation logs closes elastic#69188
pgomulka
added a commit
that referenced
this pull request
Feb 23, 2021
pgomulka
added a commit
that referenced
this pull request
Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #46106. Simplify the implementation of deprecation logging by
relying of log4j more completely, and implementing additional behaviour
through custom appenders and filters.