Add a "verbose" option to the data frame analytics stats endpoint #59589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
przemekwitek
force-pushed
the
dfa_stats_verbose
branch
2 times, most recently
from
2bb587b to
7eeb1c4
Compare
|
Pinging @elastic/ml-core (:ml) |
...va/org/elasticsearch/xpack/core/ml/action/GetDataFrameAnalyticsStatsActionResponseTests.java
Show resolved
Hide resolved
|
run elasticsearch-ci/bwc |
|
run elasticsearch-ci/default-distro |
przemekwitek
force-pushed
the
dfa_stats_verbose
branch
from
d551816 to
cecaa26
Compare
przemekwitek
added a commit
to przemekwitek/elasticsearch
that referenced
this pull request
Jul 15, 2020
przemekwitek
added a commit
that referenced
this pull request
Jul 16, 2020
61 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The data frame analytics stats endpoint can return extremely verbose information that is only useful if it is plotted on a chart.
This PR adds a
?verboseoption to allow the API user to hide some parts of the response.This is achieved the following way:
verboseparam is now returned by theRestGetDataFrameAnalyticsStatsAction.responseParamsmethodGetDataFrameAnalyticsStatsAction.Response.toXContentmethod translatesverboseparam tofor_internal_storageparamfor_internal_storageparam is used byValidationLoss.toXContentmethod to either output or hidefold_valuesfield.The change is a no-op to indexing code (as it sets
for_internal_storageparam totrue). It only affects_statsendpoint.The only field that this PR allows to hide is
fold_values. All the other fields in the_statsresponse have bounded size (are not arrays nor lists) so I think the user cannot gain much by hiding them.Relates #59125