Rename cat.transform => cat.transforms #54438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mpdreamz
added
:Core/Infra/REST API
|
Pinging @elastic/es-core-infra (:Core/Infra/REST API) |
|
Shouldn't the API itself be also renamed to |
|
It should and with it also all the references to it in the rest tests. Updated @karmi, thanks! |
pugnascotia
approved these changes
Mar 31, 2020
38 tasks
To match the url. We typically prefer singular url nouns but _cat tends to use plural and this API does in fact uses `/_cat/transforms`
Mpdreamz
force-pushed
the
fix/master/transform-cat-plural
branch
from
120d4c3
to
2669a28
Compare
Mpdreamz
added a commit
that referenced
this pull request
Apr 2, 2020
* Rename cat.transform => cat.transforms To match the url. We typically prefer singular url nouns but _cat tends to use plural and this API does in fact uses `/_cat/transforms` * also rename the api in the spec and tests (cherry picked from commit c495d22)
Mpdreamz
added a commit
that referenced
this pull request
Apr 2, 2020
* Rename cat.transform => cat.transforms To match the url. We typically prefer singular url nouns but _cat tends to use plural and this API does in fact uses `/_cat/transforms` * also rename the api in the spec and tests (cherry picked from commit c495d22)
|
Pinging @elastic/ml-core (:ml/Transform) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To match the url.
We typically prefer singular url nouns but _cat tends to use plural and
this API does in fact uses
/_cat/transformsRelates to the change made in #54196