Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename cat.transform => cat.transforms #54438

Merged
merged 2 commits into from
Apr 2, 2020

Conversation

Mpdreamz
Copy link
Member

To match the url.

We typically prefer singular url nouns but _cat tends to use plural and
this API does in fact uses /_cat/transforms

Relates to the change made in #54196

@Mpdreamz Mpdreamz added :Core/Infra/REST API REST infrastructure and utilities v7.7.0 v7.8.0 v8.0.0 labels Mar 30, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/REST API)

@karmi
Copy link
Contributor

karmi commented Mar 30, 2020

Shouldn't the API itself be also renamed to cat.transforms inside the JSON spec?

@Mpdreamz
Copy link
Member Author

It should and with it also all the references to it in the rest tests. Updated @karmi, thanks!

To match the url.

We typically prefer singular url nouns but _cat tends to use plural and
this API does in fact uses `/_cat/transforms`
@Mpdreamz Mpdreamz force-pushed the fix/master/transform-cat-plural branch from 120d4c3 to 2669a28 Compare April 2, 2020 06:49
@Mpdreamz Mpdreamz merged commit c495d22 into elastic:master Apr 2, 2020
@Mpdreamz Mpdreamz deleted the fix/master/transform-cat-plural branch April 2, 2020 07:40
Mpdreamz added a commit that referenced this pull request Apr 2, 2020
* Rename cat.transform => cat.transforms

To match the url.

We typically prefer singular url nouns but _cat tends to use plural and
this API does in fact uses `/_cat/transforms`

* also rename the api in the spec and tests

(cherry picked from commit c495d22)
Mpdreamz added a commit that referenced this pull request Apr 2, 2020
* Rename cat.transform => cat.transforms

To match the url.

We typically prefer singular url nouns but _cat tends to use plural and
this API does in fact uses `/_cat/transforms`

* also rename the api in the spec and tests

(cherry picked from commit c495d22)
@droberts195 droberts195 added the :ml/Transform Transform label Apr 2, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (:ml/Transform)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants