Avoid I/O operations when rewriting shard search request #54044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimczi
added
>non-issue
:Distributed/Engine
|
Pinging @elastic/es-distributed (:Distributed/Engine) |
This commit ensures that we rewrite the shard request with a short-lived can_match searcher. This is required for frozen indices since the high level rewrite is now performed on a network thread where we don't want to perform I/O. Closes elastic#53985
jimczi
force-pushed
the
rewrite_search_can_match
branch
from
5f57460
to
cba588b
Compare
jpountz
approved these changes
Mar 24, 2020
server/src/main/java/org/elasticsearch/search/internal/ShardSearchRequest.java
Show resolved
Hide resolved
jimczi
added a commit
that referenced
this pull request
Mar 25, 2020
jimczi
added a commit
that referenced
this pull request
Mar 25, 2020
jimczi
added a commit
that referenced
this pull request
Mar 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit ensures that we rewrite the shard request with a short-lived can_match searcher.
This is required for frozen indices since the high level rewrite is now performed on a network thread (#51708) where we don't want to perform I/O.
This fixes a bug that is only present in master and 7.x (unreleased versions), hence the
non-issuelabel.Closes #53985