Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce aarch64 Docker image #53936

Merged
merged 4 commits into from
Mar 23, 2020
Merged

Conversation

jasontedor
Copy link
Member

This commit introduces the infrastructure needed to build a Docker image for aarch64.

Relates #53914

This commit introduces the infrastructure needed to build a Docker image
for aarch64.
@jasontedor jasontedor added >enhancement :Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts v8.0.0 v7.7.0 labels Mar 22, 2020
Copy link
Contributor

@pugnascotia pugnascotia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good.

I wondered whether it was worth gathering the various bits of architecture-related data into a couple of enums? E.g. (incomplete):

public enum DockerArchitecture {
    X_64("linux-x86_64", "centos:7", ""),
    AARCH_64("linux-aarch64", "arm64v8/centos:7", "-arm64");

    public final String classifier;
    public final String dockerImage;
    public final String tiniSuffix;

    DockerArchitecture(String classifier, String dockerImage, String tiniSuffix) {
        this.classifier = classifier;
        this.dockerImage = dockerImage;
        this.tiniSuffix = tiniSuffix;
    }
}

@jasontedor jasontedor merged commit 4af4eb9 into elastic:master Mar 23, 2020
jasontedor added a commit that referenced this pull request Mar 23, 2020
This commit introduces the infrastructure needed to build a Docker image
for aarch64.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts >enhancement Team:Delivery Meta label for Delivery team v7.7.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants