-
Notifications
You must be signed in to change notification settings - Fork 24.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Improve DF analytics audits and logging #53179
[ML] Improve DF analytics audits and logging #53179
Conversation
Adds audits for when the job starts reindexing, loading data, analyzing, writing results. Also adds some info logging.
Pinging @elastic/ml-core (:ml) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -233,6 +233,8 @@ protected static void assertThatAuditMessagesMatch(String configId, String... ex | |||
// Since calls to write the AbstractAuditor are sent and forgot (async) we could have returned from the start, | |||
// finished the job (as this is a very short analytics job), all without the audit being fully written. | |||
assertBusy(() -> assertTrue(indexExists(NotificationsIndex.NOTIFICATIONS_INDEX))); | |||
client().admin().indices().prepareRefresh(".ml-notifications*").get(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this needed taking into account that fetchAllAuditMessages
also issues refresh request?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, good point. That comment got me confused. I'll remove.
Adds audits for when the job starts reindexing, loading data,
analyzing, writing results. Also adds some info logging.