Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt searchable snapshots code to latest master changes #52258

Merged
merged 2 commits into from
Feb 12, 2020

Conversation

tlrx
Copy link
Member

@tlrx tlrx commented Feb 12, 2020

This pull request adapts searchable snapshots to the latest changes from master.

The REST handlers declare their routes differently since #51950 and SearchableSnapshotIndexInput need to account for segment infos files that are stored in shard snapshot metadata hash and not uploaded to the blob store anymore since #51729.

@tlrx tlrx added >non-issue :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs labels Feb 12, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore)

Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; one suggestion about an exception message.

@tlrx tlrx merged commit c97c97c into elastic:feature/searchable-snapshots Feb 12, 2020
@tlrx tlrx deleted the after-merging-master branch February 12, 2020 11:21
@tlrx
Copy link
Member Author

tlrx commented Feb 12, 2020

Thanks David!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >non-issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants