Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the query builder serialization from QueryShardException message #51885

Merged
merged 2 commits into from
Feb 6, 2020

Commits on Feb 4, 2020

  1. Remove the query builder serialization from QueryShardException message

    QueryBuilders that throw exceptions on shards when building the Lucene query
    returns the full serialization of the query builder in the exception message.
    For large queries that fails to execute due to the max boolean clause, this means
    that we keep a reference of these big messages for every shard that participate
    in the request. In order to limit the memory needed to hold these query shard
    exceptions in the coordinating node, this change removes the query builder
    serialization from the shard exception. The query is known by the user so
    there should be no need to repeat it on every shard exception. We could also
    omit the entire stack trace for known bad request exception but it would deserve
    a separate issue/pr.
    
    Closes elastic#51843
    Closes elastic#48910
    jimczi committed Feb 4, 2020
    Configuration menu
    Copy the full SHA
    eb9f453 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2020

  1. Configuration menu
    Copy the full SHA
    dadd75e View commit details
    Browse the repository at this point in the history