-
Notifications
You must be signed in to change notification settings - Fork 24.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always rewrite search shard request outside of the search thread pool #51708
Merged
jimczi
merged 12 commits into
elastic:master
from
jimczi:rewrite_shard_request_no_rejection
Feb 6, 2020
Merged
Always rewrite search shard request outside of the search thread pool #51708
jimczi
merged 12 commits into
elastic:master
from
jimczi:rewrite_shard_request_no_rejection
Feb 6, 2020
Commits on Jan 30, 2020
-
Always rewrite search shard request outside of the search thread pool
This change ensures that the rewrite of the shard request is executed in the network thread or in the refresh listener when waiting for an active shard. This allows queries that rewrite to match_no_docs to bypass the search thread pool entirely even if the can_match phase was skipped (pre_filter_shard_size > number of shards). Coordinating nodes don't have the ability to create empty responses so this change also ensures that at least one shard creates a full empty response while the other can return null ones. This is needed since creating true empty responses on shards require to create concrete aggregators which would be too costly to build on a network thread. We should move this functionality to aggregation builders in a follow up but that would be a much bigger change. This change is also important for elastic#49601 since we want to add the ability to use the result of other shards to rewrite the request of subsequent ones. For instance if the first M shards have their top N computed, the top worst document in the global queue can be pass to subsequent shards that can then rewrite to match_no_docs if they can guarantee that they don't have any document better than the provided one.
Configuration menu - View commit details
-
Copy full SHA for 28fa23b - Browse repository at this point
Copy the full SHA 28fa23bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 534b552 - Browse repository at this point
Copy the full SHA 534b552View commit details -
Configuration menu - View commit details
-
Copy full SHA for c02f352 - Browse repository at this point
Copy the full SHA c02f352View commit details -
Configuration menu - View commit details
-
Copy full SHA for 010ec08 - Browse repository at this point
Copy the full SHA 010ec08View commit details -
Configuration menu - View commit details
-
Copy full SHA for f5684ec - Browse repository at this point
Copy the full SHA f5684ecView commit details
Commits on Feb 3, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 0acf244 - Browse repository at this point
Copy the full SHA 0acf244View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6016fa4 - Browse repository at this point
Copy the full SHA 6016fa4View commit details -
Configuration menu - View commit details
-
Copy full SHA for a058127 - Browse repository at this point
Copy the full SHA a058127View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8534ed2 - Browse repository at this point
Copy the full SHA 8534ed2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 27cdf19 - Browse repository at this point
Copy the full SHA 27cdf19View commit details -
Configuration menu - View commit details
-
Copy full SHA for a313d1d - Browse repository at this point
Copy the full SHA a313d1dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 662972c - Browse repository at this point
Copy the full SHA 662972cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.