Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate synced flush #50835

Merged
merged 2 commits into from
Jan 13, 2020
Merged

Deprecate synced flush #50835

merged 2 commits into from
Jan 13, 2020

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Jan 10, 2020

A normal flush has the same effect as a synced flush on Elasticsearch 7.6 or later. It's deprecated in 7.6 and will be removed in 8.0.

Relates #50776

@dnhatn dnhatn added >deprecation :Distributed Indexing/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. v8.0.0 v7.6.0 labels Jan 10, 2020
@dnhatn dnhatn requested review from ywelsch and jrodewig January 10, 2020 02:54
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (:Distributed/Distributed)

@dnhatn dnhatn mentioned this pull request Jan 10, 2020
Closed
7 tasks
jrodewig
jrodewig reviewed Jan 10, 2020
View reviewed changes
Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dnhatn!

Overall, I think the docs for this are in pretty good shape. I left several non-blocking nits throughout.

The only blocking change I requested is re: the deprecated::[] note in synced-flush.asciidoc. The current deprecation block isn't rendering properly. I'd also move it higher up on the page.

@dnhatn dnhatn mentioned this pull request Jan 10, 2020
Merged
@dnhatn dnhatn changed the base branch from master to 7.x January 13, 2020 13:44
@dnhatn dnhatn changed the base branch from 7.x to master January 13, 2020 13:45
@dnhatn dnhatn changed the base branch from master to 7.x January 13, 2020 15:02
@dnhatn dnhatn force-pushed the deprecate-synced-flush branch from c5d3788 to f6f453f Compare January 13, 2020 15:02
@dnhatn dnhatn removed the v8.0.0 label Jan 13, 2020
@dnhatn
Copy link
Member Author

dnhatn commented Jan 13, 2020

Hi @jrodewig Thank you for reviewing. I've addressed your comments.

Discussed with @ywelsch on another channel, we prefer this PR make to 7.x only so we can write the docs more concise.

jrodewig
jrodewig approved these changes Jan 13, 2020
View reviewed changes
Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs LGTM. Thanks @dnhatn!

ywelsch
ywelsch approved these changes Jan 13, 2020
View reviewed changes
Copy link
Contributor

@ywelsch ywelsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnhatn
Copy link
Member Author

dnhatn commented Jan 13, 2020

Thanks James and Yannick!

@dnhatn dnhatn merged commit 1a32d71 into elastic:7.x Jan 13, 2020
@dnhatn dnhatn deleted the deprecate-synced-flush branch January 13, 2020 15:58
dnhatn added a commit that referenced this pull request Jan 13, 2020
@dnhatn
Revert "Deprecate synced flush (#50835)"
05f97d5 
This reverts commit 1a32d71.
dnhatn added a commit that referenced this pull request Jan 14, 2020
@dnhatn
Deprecate synced flush (#50835)
fb32a55 
A normal flush has the same effect as a synced flush on Elasticsearch 
7.6 or later. It's deprecated in 7.6 and will be removed in 8.0.

Relates #50776
dnhatn added a commit that referenced this pull request Jan 14, 2020
@dnhatn
Deprecate synced flush (#50835)
08b8450 
A normal flush has the same effect as a synced flush on Elasticsearch
7.6 or later. It's deprecated in 7.6 and will be removed in 8.0.

Relates #50776
@dnhatn dnhatn added the v8.0.0 label Jan 14, 2020
SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this pull request Jan 23, 2020
@dnhatn @SivagurunathanV
Deprecate synced flush (elastic#50835)
276b0ed 
A normal flush has the same effect as a synced flush on Elasticsearch
7.6 or later. It's deprecated in 7.6 and will be removed in 8.0.

Relates elastic#50776
@dnhatn dnhatn mentioned this pull request Jan 28, 2020
Merged
This was referenced Feb 3, 2020
Closed
Closed
russcam added a commit that referenced this pull request Feb 5, 2020
@russcam
Use deprecated object to deprecate synced flush API
f418b6f 
Relates: #50835

This commit updates the synced flush REST API to
use the deprecated object to deprecate the whole API.
@russcam russcam mentioned this pull request Feb 5, 2020
Closed
russcam added a commit to russcam/elasticsearch that referenced this pull request May 25, 2020
@russcam
Use deprecated object to deprecate synced flush API
ec4c480 
Relates: elastic#50835

This commit updates the synced flush REST API spec to
deprecate the whole API.
@russcam russcam mentioned this pull request May 25, 2020
Merged
russcam added a commit that referenced this pull request Aug 6, 2020
@russcam
Use deprecated object to deprecate synced flush API (#57096)
d593c96 
Relates: #50835

This commit updates the synced flush REST API spec to
deprecate the whole API.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ywelsch ywelsch ywelsch approved these changes

@jrodewig jrodewig jrodewig approved these changes

Assignees
No one assigned
Labels
>deprecation :Distributed Indexing/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. v7.6.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dnhatn @elasticmachine @ywelsch @jrodewig @jakelandis