Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] retry bulk indexing of state docs #50149

Merged
merged 1 commit into from
Dec 13, 2019
Merged

[ML] retry bulk indexing of state docs #50149

merged 1 commit into from
Dec 13, 2019

Conversation

benwtrent
Copy link
Member

This exchanges the direct use of the Client for ResultsPersisterService. State doc persistence will now retry. Failures to persist state will still not throw, but will be audited and logged.

closes #50143

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (:ml)

davidkyle
davidkyle approved these changes Dec 13, 2019
View reviewed changes
Copy link
Member

@davidkyle davidkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

One nit is that ResultsPersisterService is a general class now used for state as well as results now, it doesn't know anything about anomaly detector results classes. Maybe it is just a PersistenceService or RetryPersistenceService

@benwtrent benwtrent merged commit 681e9fd into elastic:master Dec 13, 2019
@benwtrent benwtrent deleted the feature/ml-retry-state-bulk-indexing branch December 13, 2019 14:45
benwtrent added a commit to benwtrent/elasticsearch that referenced this pull request Dec 13, 2019
@benwtrent
[ML] retry bulk indexing of state docs (elastic#50149)
bf57e14 
This exchanges the direct use of the `Client` for `ResultsPersisterService`. State doc persistence will now retry. Failures to persist state will still not throw, but will be audited and logged.
@benwtrent benwtrent mentioned this pull request Dec 13, 2019
Merged
benwtrent added a commit that referenced this pull request Dec 13, 2019
@benwtrent
[ML] retry bulk indexing of state docs (#50149) (#50185)
41736dd 
This exchanges the direct use of the `Client` for `ResultsPersisterService`. State doc persistence will now retry. Failures to persist state will still not throw, but will be audited and logged.
@droberts195
Copy link
Contributor

@dimitris-athanasiou in case you didn't notice, this PR also covers retries for indexing data frame analytics state, as the state is persisted by the same IndexingStateProcessor class. So I think it's just data frame updates for data frame analytics jobs that need retries adding now for complete cross-plugin consistency.

SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this pull request Jan 23, 2020
@benwtrent @SivagurunathanV
[ML] retry bulk indexing of state docs (elastic#50149)
1c2b083 
This exchanges the direct use of the `Client` for `ResultsPersisterService`. State doc persistence will now retry. Failures to persist state will still not throw, but will be audited and logged.
This was referenced Feb 3, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidkyle davidkyle davidkyle approved these changes

Assignees
No one assigned
Labels
>enhancement :ml Machine learning v7.6.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ML] Gracefully handle and retry state bulk indexing failures
5 participants
@benwtrent @elasticmachine @droberts195 @davidkyle @jakelandis