[ML] Remove usage of base action logger in ml actions #50074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core (:ml) |
|
Do we want to remove those? I think they're useful debug messages. It's just that they use the master |
davidkyle
changed the title
|
I change this PR to use a specific new logger in ml action rather than the base class logger and reverted the removal of the debug messages |
|
@elasticmachine update branch |
usage collector
This reverts commit 91095af3a793e6811b49324182d52897efd81d32.
davidkyle
added a commit
that referenced
this pull request
Dec 17, 2019
This was referenced Jan 10, 2020
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetJobStats,GetDataFrameAnalyticsStatsandGetDatafeedStatsare all called by the telemetry usage collector, these debug level messages can result in a lot of noise and add little value.The default log4j configuration sets the log level to debug for the
org.elasticsearch.actionpackage, any transport actions that use the logger in the base classTransportActionwill log at this level. Create a logger in the ml actions where required, using the base logger is deprecated anyway so this change removes a few warnings.Also changed the naming from
LOGGERto the more typicalloggerI also checked the Transforms actions and there are no problems there.
Closes #50056