Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a cluster setting to disallow loading fielddata on _id field #49166

Merged
merged 5 commits into from
Nov 27, 2019

Commits on Nov 22, 2019

  1. Add a cluster setting to disallow loading fielddata on _id field

    This change adds a dynamic cluster setting named `indices.id_field_data.enabled`.
    When set to `false` any attempt to load the fielddata for the `_id` field will fail
    with an exception. The default value in this change is set to `false` in order to prevent
    fielddata usage on this field for future versions but it will be set to `true` when backporting
    to 7x. When the setting is set to true (manually or by default in 7x) the loading will also issue
    a deprecation warning since we want to disallow fielddata entirely when elastic#26472
    is implemented.
    
    Closes elastic#43599
    jimczi committed Nov 22, 2019
    Configuration menu
    Copy the full SHA
    2768165 View commit details
    Browse the repository at this point in the history
  2. fix security tests

    jimczi committed Nov 22, 2019
    Configuration menu
    Copy the full SHA
    537db09 View commit details
    Browse the repository at this point in the history
  3. Update server/src/main/java/org/elasticsearch/index/mapper/IdFieldMap…

    …per.java
    
    
    Rewording
    
    Co-Authored-By: Adrien Grand <jpountz@gmail.com>
    jimczi and jpountz committed Nov 22, 2019
    Configuration menu
    Copy the full SHA
    edd4cb6 View commit details
    Browse the repository at this point in the history
  4. address review

    jimczi committed Nov 22, 2019
    Configuration menu
    Copy the full SHA
    e8aa2c4 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2019

  1. Configuration menu
    Copy the full SHA
    ff3cf6e View commit details
    Browse the repository at this point in the history