Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Reformat common grams token filter #48426

Merged
merged 1 commit into from
Oct 30, 2019
Merged

[DOCS] Reformat common grams token filter #48426

merged 1 commit into from
Oct 30, 2019

Conversation

jrodewig
Copy link
Contributor

Reformats the common grams token filter docs as part of #44726.

Changes

  • Adds a title abbreviation
  • Updates the description and adds a Lucene link
  • Separates the analyzer and analyze API examples
  • Updates parameter documentation
  • Separates the analyzer example to only include a single filter

@jrodewig jrodewig added >docs General docs changes :Search Relevance/Analysis How text is split into tokens v8.0.0 v7.5.0 v7.6.0 v7.4.2 labels Oct 23, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Analysis)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

@kat257 kat257 mentioned this pull request Oct 23, 2019
Closed
82 tasks
@jrodewig jrodewig requested a review from romseygeek October 29, 2019 17:45
romseygeek
romseygeek approved these changes Oct 30, 2019
View reviewed changes
Copy link
Contributor

@romseygeek romseygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrodewig jrodewig merged commit 60f9de5 into elastic:master Oct 30, 2019
@jrodewig jrodewig deleted the reformat.common-grams-tokenfilter branch October 30, 2019 12:40
jrodewig added a commit that referenced this pull request Oct 30, 2019
@jrodewig
[DOCS] Reformat common grams token filter (#48426)
77acbc4
jrodewig added a commit that referenced this pull request Oct 30, 2019
@jrodewig
[DOCS] Reformat common grams token filter (#48426)
4204b2c
jrodewig added a commit that referenced this pull request Oct 30, 2019
@jrodewig
[DOCS] Reformat common grams token filter (#48426)
569fb14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romseygeek romseygeek romseygeek approved these changes

Assignees
No one assigned
Labels
>docs General docs changes :Search Relevance/Analysis How text is split into tokens v7.4.2 v7.5.0 v7.6.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jrodewig @elasticmachine @romseygeek @jakelandis