BlendedTermQuery's equals method should consider boosts #48193
Conversation
This changes the queries equals() method so that the boost factors for each term are considered for the equality calculation. This means queries are only equal if both their terms and associated boosts match. The ordering of the terms doesn't matter as before, which is why we internally need to sort the terms and boost for comparison on the first equals() call like before. Boosts that are `null` are considered equal to boosts of 1.0f because topLevelQuery() will only wrap into BoostQuery if boost is not null and different from 1f. Closes elastic#48184
cbuescher
added
>enhancement
:Search/Search
|
Pinging @elastic/es-search (:Search/Search) |
| } | ||
|
|
||
| TermAndBoost that = (TermAndBoost) o; | ||
| return term.equals(that.term) && boost == that.boost; |
There was a problem hiding this comment.
should we compare boosts as Float.compare(boost, that.boost) ==0 ?
There was a problem hiding this comment.
True, wrong old habits don die easily...
There was a problem hiding this comment.
thanks @cbuescher. Nice addition.
Not completely related to your PR, I wonder how ES BlendedTermQuery is related to Lucene's BlendedTermQuery?
I don't really know tbh. but on cursory inspection they seem to be working differently, e.g. the way they rewrite against an IndexReader seem to follow different logic (the Lucene one having different RewriteMethods while the ES ones offers to overwrite topLevelQuery(), which in the one case I see produces a DisjunctionMaxQuery). |
This changes the queries equals() method so that the boost factors for each term are considered for the equality calculation. This means queries are only equal if both their terms and associated boosts match. The ordering of the terms doesn't matter as before, which is why we internally need to sort the terms and boost for comparison on the first equals() call like before. Boosts that are `null` are considered equal to boosts of 1.0f because topLevelQuery() will only wrap into BoostQuery if boost is not null and different from 1f. Closes #48184
This changes the queries equals() method so that the boost factors for each term are considered for the equality calculation. This means queries are only equal if both their terms and associated boosts match. The ordering of the terms doesn't matter as before, which is why we internally need to sort the terms and boost for comparison on the first equals() call like before. Boosts that are `null` are considered equal to boosts of 1.0f because topLevelQuery() will only wrap into BoostQuery if boost is not null and different from 1f. Closes #48184
This changes the queries equals() method so that the boost factors for each term
are considered for the equality calculation. This means queries are only equal
if both their terms and associated boosts match. The ordering of the terms
doesn't matter as before, which is why we internally need to sort the terms and
boost for comparison on the first equals() call like before. Boosts that are
nullare considered equal to boosts of 1.0f because topLevelQuery() will onlywrap into BoostQuery if boost is not null and different from 1f.
Closes #48184