-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to filter ILM explain response #44777
Conversation
In order to make it easier to interpret the output of the ILM Explain API, this commit adds two request parameters to that API: - `only_managed`, which causes the response to only contain indices which have `index.lifecycle.name` set - `only_errors`, which causes the response to contain only indices in an ILM error state "Error state" is defined as either being in the `ERROR` step or having `index.lifecycle.name` set to a policy that does not exist.
Pinging @elastic/es-core-features |
@@ -21,13 +23,48 @@ | |||
* {@link #indices(String...)} method | |||
*/ | |||
public class ExplainLifecycleRequest extends ClusterInfoRequest<ExplainLifecycleRequest> { | |||
private static final Version FILTERS_INTRODUCED_VERSION = Version.V_8_0_0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: Update this in the backport and in master after merging the backport.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the serialization version in a76242d now that the backport has been merged.
@elasticmachine run elasticsearch-ci/1 Opened #44778 for the failure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, do you think it's worth adding something to the REST tests for ILM that uses it? Up to you either way.
Good idea @dakrone, I've added a couple basic tests. |
In order to make it easier to interpret the output of the ILM Explain API, this commit adds two request parameters to that API: - `only_managed`, which causes the response to only contain indices which have `index.lifecycle.name` set - `only_errors`, which causes the response to contain only indices in an ILM error state "Error state" is defined as either being in the `ERROR` step or having `index.lifecycle.name` set to a policy that does not exist.
In order to make it easier to interpret the output of the ILM Explain API, this commit adds two request parameters to that API: - `only_managed`, which causes the response to only contain indices which have `index.lifecycle.name` set - `only_errors`, which causes the response to contain only indices in an ILM error state "Error state" is defined as either being in the `ERROR` step or having `index.lifecycle.name` set to a policy that does not exist.
In order to make it easier to interpret the output of the ILM Explain API, this commit adds two request parameters to that API: - `only_managed`, which causes the response to only contain indices which have `index.lifecycle.name` set - `only_errors`, which causes the response to contain only indices in an ILM error state "Error state" is defined as either being in the `ERROR` step or having `index.lifecycle.name` set to a policy that does not exist.
In order to make it easier to interpret the output of the ILM Explain
API, this commit adds two request parameters to that API:
only_managed
, which causes the response to only contain indiceswhich have
index.lifecycle.name
setonly_errors
, which causes the response to contain only indices in anILM error state
"Error state" is defined as either being in the
ERROR
step or havingindex.lifecycle.name
set to a policy that does not exist.Closes #44189