Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "manage_api_key" cluster privilege #43728

Merged
merged 1 commit into from
Jul 1, 2019

Conversation

tvernum
Copy link
Contributor

@tvernum tvernum commented Jun 28, 2019

This adds a new cluster privilege for manage_api_key. Users with this
privilege are able to create new API keys (as a child of their own
user identity) and may also get and invalidate any/all API keys
(including those owned by other users).

This also fixes a bug where the security index was accessed using the
authenticated user's context, which meant that only superuser was
able to call these APIs. The API Key actions may now be called by any
user with manage_security or manage_api_key.

Relates: #42020

This adds a new cluster privilege for manage_api_key. Users with this
privilege are able to create new API keys (as a child of their own
user identity) and may also get and invalidate any/all API keys
(including those owned by other users).
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security

@tvernum
Copy link
Contributor Author

tvernum commented Jun 28, 2019

I still need to add this cluster privilege to the docs, but I wanted to get a PR up for review today. The docs might need to wait until next week.

Copy link
Contributor

@albertzaharovits albertzaharovits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@bizybot bizybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you.

@tvernum tvernum merged commit 324ee42 into elastic:master Jul 1, 2019
tvernum added a commit to tvernum/stack-docs that referenced this pull request Jul 1, 2019
tvernum added a commit to tvernum/elasticsearch that referenced this pull request Jul 1, 2019
Add the "Authorization" section to the API key API docs.
These APIs require The new manage_api_key cluster privilege.

Relates: elastic#43728
tvernum added a commit that referenced this pull request Jul 2, 2019
Add the "Authorization" section to the API key API docs.
These APIs require The new manage_api_key cluster privilege.

Relates: #43728
tvernum added a commit to tvernum/elasticsearch that referenced this pull request Jul 2, 2019
This adds a new cluster privilege for manage_api_key. Users with this
privilege are able to create new API keys (as a child of their own
user identity) and may also get and invalidate any/all API keys
(including those owned by other users).

Backport of: elastic#43728
tvernum added a commit that referenced this pull request Jul 2, 2019
This adds a new cluster privilege for manage_api_key. Users with this
privilege are able to create new API keys (as a child of their own
user identity) and may also get and invalidate any/all API keys
(including those owned by other users).

Backport of: #43728
tvernum added a commit to tvernum/elasticsearch that referenced this pull request Jul 2, 2019
Add the "Authorization" section to the API key API docs.
These APIs require The new manage_api_key cluster privilege.

Relates: elastic#43728
Backport of: elastic#43811
tvernum added a commit to elastic/stack-docs that referenced this pull request Jul 4, 2019
Relates: elastic/elasticsearch#43728

Co-Authored-By: Lisa Cawley <lcawley@elastic.co>
tvernum added a commit to elastic/stack-docs that referenced this pull request Jul 16, 2019
Relates: elastic/elasticsearch#43728

Co-Authored-By: Lisa Cawley <lcawley@elastic.co>

Backport of: #395
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants