Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated search.remote settings #42381

Merged

Conversation

jasontedor
Copy link
Member

@jasontedor jasontedor commented May 22, 2019

We deprecated these settings awhile ago, in favor of cluster.remote. In 7.x we were gentle and provided automatic upgrade of these settings to the new settings. Now it is time for them to go. This commit removes the deprecated search.remote settings.

Relates #33413
Relates #38556

We deprecated these settings awhile ago, in favor of cluster.remote. In
7.x we were gentle and provided automatic upgrade of these settings to
the new settings. Now it is time for them to go. This commit removes the
deprecated search.remote settings.
@jasontedor jasontedor added >breaking :Search/Search Search-related issues that do not fall into other categories v8.0.0 labels May 22, 2019
@jasontedor jasontedor requested review from rjernst and s1monw May 22, 2019 17:43
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search

Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hooray for good comments on what the code should be when fallback is removed! LGTM

@jasontedor
Copy link
Member Author

Hooray for good comments on what the code should be when fallback is removed!

Thanks past self!

…search-remote-settings

* elastic/master:
  Make packer cache branches explicit (elastic#41990)
  Re-mute all ml_datafeed_crud rolling upgrade tests
  Ensure testAckedIndexing uses disruption index settings
  add 7_3 as version (elastic#42368)
  Fix grammar problem in stemming reference. (elastic#42148)
Copy link
Contributor

@s1monw s1monw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 2

@jasontedor
Copy link
Member Author

@elasticmachine run elasticsearch-ci/1

2 similar comments
@jasontedor
Copy link
Member Author

@elasticmachine run elasticsearch-ci/1

@jasontedor
Copy link
Member Author

@elasticmachine run elasticsearch-ci/1

@jasontedor jasontedor merged commit 1b0c728 into elastic:master May 23, 2019
@jasontedor jasontedor deleted the remove-deprecated-search-remote-settings branch May 23, 2019 15:06
gurkankaymak pushed a commit to gurkankaymak/elasticsearch that referenced this pull request May 27, 2019
We deprecated these settings awhile ago, in favor of cluster.remote. In
7.x we were gentle and provided automatic upgrade of these settings to
the new settings. Now it is time for them to go. This commit removes the
deprecated search.remote settings.
masseyke added a commit that referenced this pull request Sep 1, 2021
The search.remote.* properties have been removed in 8.0 and replaced with cluster.remote.* properties.
This adds a check for these properties in the deprecation info API.
Relates #42404 and #42381
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>breaking :Search/Search Search-related issues that do not fall into other categories v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants