Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNAPSHOT: Use CancellableThreads to Abort #35901

Closed
wants to merge 3 commits into from

Conversation

original-brownbear
Copy link
Member

@original-brownbear original-brownbear added >enhancement :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs v7.0.0 v6.6.0 labels Nov 26, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

@jasontedor jasontedor added v6.7.0 and removed v6.6.0 labels Dec 19, 2018
@ywelsch
Copy link
Contributor

ywelsch commented Dec 27, 2018

This depends on #32512

@original-brownbear
Copy link
Member Author

@ywelsch maybe I can just move this to using ActionListener instead of CompletableFuture, I wasn't aware of #32512 when I opened this, but it seems I can do the same thing with ActionListener just fine :)?

@ywelsch
Copy link
Contributor

ywelsch commented Jan 11, 2019

I'm inclined not to go forward with this, as we're unaware of the consequences of interrupting threads in the third-party SDKs that we're using.

@original-brownbear
Copy link
Member Author

Right, closing here :) Will investigate making this async instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >enhancement v6.7.0 v7.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants