Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Move CCR overview pages #34918

Merged
merged 3 commits into from
Nov 2, 2018
Merged

[DOCS] Move CCR overview pages #34918

merged 3 commits into from
Nov 2, 2018

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Oct 26, 2018

Related to #34726 and elastic/stack-docs#132

This PR removes the CCR overview pages from the Elasticsearch Reference (since they exist in the Stack Overview here: https://www.elastic.co/guide/en/elastic-stack-overview/master/xpack-ccr.html). It also updates the title of the CCR section so that it aligns with the other titles.

@lcawl lcawl added >docs General docs changes v7.0.0 :Distributed/CCR Issues around the Cross Cluster State Replication features v6.5.0 v6.6.0 labels Oct 26, 2018
@lcawl lcawl requested a review from jasontedor October 26, 2018 16:18
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

@lcawl lcawl changed the title [DOCS] [DOCS] Move CCR overview pages Oct 26, 2018
Copy link
Member

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a question.

@@ -55,8 +55,6 @@ include::index-modules.asciidoc[]

include::ingest.asciidoc[]

include::ccr/index.asciidoc[]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -1,7 +1,7 @@
[role="xpack"]
[testenv="platinum"]
[[xpack-ccr]]
= Cross-cluster replication
= Replicating data across multiple clusters
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious what is the reason for this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a necessity, but it seemed to align better with the titles of similar sections in the table of contents ("securing", "alerting", "monitoring").

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I prefer "Cross-cluster replication". It's easier to discover (grep, searches, etc.).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok! I've reverted that change.

Copy link
Member

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lcawl lcawl merged commit 3c36ba1 into elastic:master Nov 2, 2018
@lcawl lcawl deleted the lcawley-ccr branch November 2, 2018 21:23
lcawl added a commit that referenced this pull request Nov 2, 2018
lcawl added a commit that referenced this pull request Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed/CCR Issues around the Cross Cluster State Replication features >docs General docs changes v6.5.0 v6.6.0 v7.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants