[CCR Monitoring] Only collect stats for specified indices #33646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-core-infra |
ycombinator
commented
Sep 12, 2018
| @@ -72,7 +72,7 @@ protected boolean shouldCollect(final boolean isElectedMaster) { | |||
| final ClusterState clusterState) throws Exception { | |||
| try (ThreadContext.StoredContext ignore = stashWithOrigin(threadContext, MONITORING_ORIGIN)) { | |||
| final CcrStatsAction.StatsRequest request = new CcrStatsAction.StatsRequest(); | |||
| request.setIndices(Strings.EMPTY_ARRAY); | |||
| request.setIndices(getCollectionIndices()); | |||
There was a problem hiding this comment.
Additionally, would it make sense to also set the following?
request.setIndicesOptions(IndicesOptions.lenientExpandOpen());The IndexRecoveryCollector and IndexStatsCollector do this too.
There was a problem hiding this comment.
I think that makes sense. Otherwise we may throw an index not found exception if the index patterns the user is interested in does not yet exist.
There was a problem hiding this comment.
btw the build fails because of the removal of String.EMPTY_ARRAY its import is now unused.
jasontedor
added
:Distributed Indexing/CCR
|
Pinging @elastic/es-distributed |
ycombinator
added a commit
to ycombinator/elasticsearch
that referenced
this pull request
Sep 18, 2018
) Follow up to elastic#33617. Relates to elastic#30086. As with all other per-index Monitoring collectors, the `CcrStatsCollector` should only collect stats for the indices the user wants to monitor. This list is controlled by the `xpack.monitoring.collection.indices` setting and defaults to all indices.
ycombinator
added a commit
that referenced
this pull request
Sep 18, 2018
Backport of #33646 to 6.x. Original message: Follow up to #33617. Relates to #30086. As with all other per-index Monitoring collectors, the `CcrStatsCollector` should only collect stats for the indices the user wants to monitor. This list is controlled by the `xpack.monitoring.collection.indices` setting and defaults to all indices.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #33617. Relates to #30086.
As with all other per-index Monitoring collectors, the
CcrStatsCollectorshould only collect stats for the indices the user wants to monitor. This list is controlled by thexpack.monitoring.collection.indicessetting and defaults to all indices.