-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CCR] Sync mappings between leader and follow index #30115
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
4330bf6
[CCR] Sync mappings between leader and follow index
martijnvg 22b0e44
Merge remote-tracking branch 'origin/ccr' into pr/30115
jasontedor 5ea5c4d
applied small feedback points
martijnvg 9635fe3
use a `Semaphore` to ensure that only one mapping update is executed
martijnvg 33f7993
rename and fixed checkstyle violations
martijnvg ac0c7fe
Merge remote-tracking branch 'es/ccr' into sync_mapping
martijnvg dc8e79f
Merge remote-tracking branch 'es/ccr' into sync_mapping
martijnvg 6a93e5d
Merge remote-tracking branch 'es/ccr' into sync_mapping
martijnvg b12d204
iter after merge
martijnvg b569f88
not retry all exceptions
martijnvg af82fc2
Merge remote-tracking branch 'es/ccr' into sync_mapping
martijnvg ed80800
fix issue after merge
martijnvg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that
Object.hash(indexMetadataVersion, operations)
is fine here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately
Object.hash(...)
doesn't handle arrays correctly, so I changed it back to useArrays.hashCode(...)
.