[Docs] Use correct formatting for links #29460
Conversation
colings86
added
the
:Search/Search
|
Pinging @elastic/es-search-aggs |
|
@dedemorton Thanks for your correction. It looks to me that these links are not necessary, as the sections are included in the main document (you can see the menu on the sub-items) on the right, and there are also links to go these sections. @debadair what do you think? |
|
I don't have a strong feeling either way. The links should either be coded correctly or removed. |
There was a problem hiding this comment.
@dedemorton @mayya-sharipova I checked how this looks like currently and I think having the links would be helpful. The links in the right menu are below the scroll line for me if I go to https://www.elastic.co/guide/en/elasticsearch/reference/6.3/recipes.html for example. I think its good to make them actual links like proposed here. Should we just merge this?
|
Actually, when I first looked at this content, all of it was on a single page. Now that the topics live on separate pages, the links are necessary. |
|
@dedemorton great, do you want to merge and backport or do you mind if I do it? |
|
@cbuescher Feel free to merge and backport! |
* es/master: (21 commits) Tweaked Elasticsearch Service links for SEO Watcher: Store username on watch execution (#31873) Use correct formatting for links (#29460) Painless: Separate PainlessLookup into PainlessLookup and PainlessLookupBuilder (#32054) Scripting: Remove dead code from painless module (#32064) [Rollup] Replace RollupIT with a ESRestTestCase version (#31977) [TEST] Consistent algorithm usage (#32077) [Rollup] Fix duplicate field names in test (#32075) Ensure only parent breaker trips in unit test Unmute field collapsing rest tests Fix BWC check after backport [Tests] Fix failure due to changes exception message (#32036) Remove unused params from SSource and Walker (#31935) [Test] Mute MlJobIT#testDeleteJobAfterMissingAliases Turn off real-mem breaker in REST tests Turn off real-mem breaker in single node tests Fix broken OpenLDAP Vagrant QA test Cleanup Duplication in `PainlessScriptEngine` (#31991) SCRIPTING: Remove unused MultiSearchTemplateRequestBuilder (#32049) Fix compile issues introduced by merge (#32058) ...
* es/6.x: Use correct formatting for links (#29460) Revert "Adds a new auto-interval date histogram (#28993)" Revert "fix typo" fix typo Adds a new auto-interval date histogram (#28993) [Rollup] Replace RollupIT with a ESRestTestCase version (#31977) [Rollup] Fix duplicate field names in test (#32075) [Tests] Fix failure due to changes exception message (#32036) [Test] Mute MlJobIT#testDeleteJobAfterMissingAliases Replace Ingest ScriptContext with Custom Interface (#32003) (#32060) Cleanup Duplication in `PainlessScriptEngine` (#31991) (#32061) HLRC: Add xpack usage api (#31975) Clean Up Snapshot Create Rest API (#31779)
Looks like someone forgot to format these as links.