Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused class PreBuiltTokenFilters #27839

Merged
merged 1 commit into from
Dec 18, 2017

Conversation

liketic
Copy link

@liketic liketic commented Dec 15, 2017

As a follow up of
// TODO remove this entire class when PreBuiltTokenizers no longer needs it.....

I think this class can be removed now.

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

Copy link
Member

@cbuescher cbuescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liketic thanks, looks quiet unused indeed. I did a quick search in the codebase and will kick of a CI run to see if anything else turns up during test (e.g. any reflection shananigans going on).

@cbuescher
Copy link
Member

@elasticmachine test this please

@cbuescher cbuescher self-assigned this Dec 15, 2017
Copy link
Member

@cbuescher cbuescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, looks like the last use of this class was removed in b9ea579

@cbuescher cbuescher merged commit 26fc717 into elastic:master Dec 18, 2017
@cbuescher
Copy link
Member

@liketic thanks a lot, I will see if I can merge this back to some 6.x branches as well

cbuescher pushed a commit that referenced this pull request Dec 18, 2017
cbuescher pushed a commit that referenced this pull request Dec 18, 2017
@liketic liketic deleted the remove-PreBuiltTokenFilters branch December 18, 2017 11:19
martijnvg added a commit that referenced this pull request Dec 18, 2017
* es/6.x: (170 commits)
  Allow TrimFilter to be used in custom normalizers (#27758)
  recovery from snapshot should fill gaps (#27850)
  Remove unused class PreBuiltTokenFilters (#27839)
  Reject scroll query if size is 0 (#22552) (#27842)
  Mutes ‘Rollover no condition matched’ YAML test
  Make randomNonNegativeLong() draw from a uniform distribution (#27856)
  Adapt rest test after backport. Relates #27833
  Handle case where the hole vertex is south of the containing polygon(s) (#27685)
  Move range field mapper back to core
  Fix publication of elasticsearch-cli to Maven
  Do not use system properties when building the HttpAsyncClient (#27829)
  Optimize version map for append-only indexing (#27752)
  Add NioGroup for use in different transports (#27737)
  adapt field collapsing skip test version. relates #27833
  Add version support for inner hits in field collapsing (#27822) (#27833)
  Clarify that number of threads is set by packages
  Register HTTP read timeout setting
  Fixes Checkstyle
  Remove `operationThreaded` from Java API (#27836)
  Fixes failing BytesSizeValues tests
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants