Add soft limit on allowed number of script fields in request #26598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbuescher
added
:Search/Search
cbuescher
commented
Sep 12, 2017
| * script fields is a costly operation. | ||
| */ | ||
| public static final Setting<Integer> MAX_SCRIPT_FIELDS_SETTING = | ||
| Setting.intSetting("index.max_script_fields", 50, 0, Property.Dynamic, Property.IndexScope); |
There was a problem hiding this comment.
note: 50 seems high enough for me, do you agree?
There was a problem hiding this comment.
I'd even go lower here maybe 32?
|
@jpountz similar to #26574, biggest question I have here is also about which versions to backport it to. I'd currently lean to merging this and similar soft limit changes to 6.0, 6.x and 7.0 to not having to introduce a change in request behaviour in a minor release. That would mean similar soft limit checks like #26492 should also be backported to 6.0? Whats your opinion on this? |
s1monw
approved these changes
Sep 12, 2017
| * script fields is a costly operation. | ||
| */ | ||
| public static final Setting<Integer> MAX_SCRIPT_FIELDS_SETTING = | ||
| Setting.intSetting("index.max_script_fields", 50, 0, Property.Dynamic, Property.IndexScope); |
There was a problem hiding this comment.
I'd even go lower here maybe 32?
Requesting to many script_fields in a search request can be costly because of script execution. This change introduces a soft limit on the number of script fields that are allowed per request. The setting can be changed per index using the index.max_script_fields setting. Relates to elastic#26390
cbuescher
force-pushed
the
fix-softLimitScriptFields
branch
from
efa599c
to
615ddb2
Compare
cbuescher
force-pushed
the
fix-softLimitScriptFields
branch
from
615ddb2
to
c5d14db
Compare
cbuescher
added a commit
that referenced
this pull request
Sep 13, 2017
Requesting to many script_fields in a search request can be costly because of script execution. This change introduces a soft limit on the number of script fields that are allowed per request. The setting can be changed per index using the index.max_script_fields setting. Relates to #26390
cbuescher
added a commit
that referenced
this pull request
Sep 13, 2017
Requesting to many script_fields in a search request can be costly because of script execution. This change introduces a soft limit on the number of script fields that are allowed per request. The setting can be changed per index using the index.max_script_fields setting. Relates to #26390
cbuescher
added a commit
that referenced
this pull request
Sep 13, 2017
After backporting the script_field soft limit to the 6.x branches, this test can now also run in a mixed cluster. Relates to #26598 enter the commit message for your changes. Lines starting
jasontedor
added a commit
to synhershko/elasticsearch
that referenced
this pull request
Sep 14, 2017
* master: (39 commits) [Docs] Correct typo in removal_of_types.asciidoc (elastic#26646) [Docs] "The the" is a great band, but ... (elastic#26644) Move all repository-azure classes under one single package (elastic#26624) [Docs] Update link in removal_of_types.asciidoc (elastic#26614) Fix percolator highlight sub fetch phase to not highlight query twice (elastic#26622) Refactor bootstrap check results and error messages Add BootstrapContext to expose settings and recovered state to bootstrap checks (elastic#26628) [Tests] Removing skipping tests in search rest tests Initialize checkpoint tracker with allocation ID Move non-core mappers to a module. (elastic#26549) [Docs] Clarify size parameter in Completion Suggester doc (elastic#26617) Add soft limit on allowed number of script fields in request (elastic#26598) Remove MapperService#dynamic. (elastic#26603) Fix incomplete sentences in parent-join docs (elastic#26623) More efficient encoding of range fields. (elastic#26470) Ensure module is bundled before installing in tests Add boolean similarity to built in similarity types (elastic#26613) [Tests] Remove skip tests in search/30_limits.yml Let search phases override max concurrent requests Add a soft limit for the number of requested doc-value fields (elastic#26574) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requesting to many script_fields in a search request can be costly
because of script execution. This change introduces a soft limit on the number
of script fields that are allowed per request. The setting can be
changed per index using the index.max_script_fields setting.
Relates to #26390