Get short path name for native controllers #25344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to limitations with CreateProcessW on Windows (ultimately used by ProcessBuilder) with respect to maximum path lengths, we need to get the short path name for any native controllers before trying to start them in case the absolute path exceeds the maximum path length. This commit uses JNA to invoke the necessary Windows API for this to start the native controller using the short path. To be precise about the limitation here, the MSDN docs for CreateProcessW say for the command line parameter: >The command line to be executed. The maximum length of this string is >32,768 characters, including the Unicode terminating null character. If >lpApplicationName is NULL, the module name portionof lpCommandLine is >limited to MAX_PATH characters. This is exactly how the Windows implementation of Process in the JDK invokes CreateProcessW: with the executable name (lpApplicationName) set to NULL.
Remove comments duplicated from MSDN (just see the source if you really need to know).
jasontedor
added a commit
that referenced
this pull request
Jun 22, 2017
Due to limitations with CreateProcessW on Windows (ultimately used by ProcessBuilder) with respect to maximum path lengths, we need to get the short path name for any native controllers before trying to start them in case the absolute path exceeds the maximum path length. This commit uses JNA to invoke the necessary Windows API for this to start the native controller using the short path. To be precise about the limitation here, the MSDN docs for CreateProcessW say for the command line parameter: >The command line to be executed. The maximum length of this string is >32,768 characters, including the Unicode terminating null character. If >lpApplicationName is NULL, the module name portionof lpCommandLine is >limited to MAX_PATH characters. This is exactly how the Windows implementation of Process in the JDK invokes CreateProcessW: with the executable name (lpApplicationName) set to NULL. Relates #25344
|
Thank you @droberts195. |
clintongormley
added
:Delivery/Packaging
droberts195
pushed a commit
that referenced
this pull request
Jul 7, 2017
Due to limitations with CreateProcessW on Windows (ultimately used by ProcessBuilder) with respect to maximum path lengths, we need to get the short path name for any native controllers before trying to start them in case the absolute path exceeds the maximum path length. This commit uses JNA to invoke the necessary Windows API for this to start the native controller using the short path. To be precise about the limitation here, the MSDN docs for CreateProcessW say for the command line parameter: >The command line to be executed. The maximum length of this string is >32,768 characters, including the Unicode terminating null character. If >lpApplicationName is NULL, the module name portionof lpCommandLine is >limited to MAX_PATH characters. This is exactly how the Windows implementation of Process in the JDK invokes CreateProcessW: with the executable name (lpApplicationName) set to NULL. Relates #25344
|
I backported this to 5.5.1 in 5d1ef7f |
|
Thank you @droberts195. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to limitations with CreateProcessW on Windows (ultimately used by ProcessBuilder) with respect to maximum path lengths, we need to get the short path name for any native controllers before trying to start them in case the absolute path exceeds the maximum path length. This commit uses JNA to invoke the necessary Windows API for this to start the native controller using the short path.
To be precise about the limitation here, the MSDN docs for CreateProcessW say for the command line parameter:
This is exactly how the Windows implementation of Process in the JDK invokes CreateProcessW: with the executable name (lpApplicationName) set to NULL.