Scripting: Remove native scripts #24726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Native scripts have been replaced in documentation by implementing a ScriptEngine and they were deprecated in 5.5.0. This commit removes the native script infrastructure for 6.0. closes elastic#19966
rjernst
added
:Core/Infra/Scripting
nik9000
approved these changes
May 17, 2017
| static float[] floatArray = { Float.MAX_VALUE, Float.MIN_VALUE, 3.3f }; | ||
| static double[] doubleArray = { Double.MAX_VALUE, Double.MIN_VALUE, 3.3d }; | ||
|
|
||
| public void testNativeScript() throws InterruptedException, ExecutionException { |
There was a problem hiding this comment.
I believe we have plenty of tests for script fields hanging around though there may not be any in core if you drop this. Is that a problem, do you think?
There was a problem hiding this comment.
This wasn't really testing script fields per say, but I will double check there is some test for script fields.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Native scripts have been replaced in documentation by implementing
a ScriptEngine and they were deprecated in 5.5.0. This commit
removes the native script infrastructure for 6.0.
closes #19966