-
Notifications
You must be signed in to change notification settings - Fork 24.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add version constant for 5.5 #24075
Add version constant for 5.5 #24075
Conversation
I'm still running tests on this locally but the build for master is totally busted without this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks for reviewing @abeyad and @jasontedor! |
Thx Nik! Should we add something to our version bumping doc?
… On 12 Apr 2017, at 10:30 PM, Nik Everett ***@***.***> wrote:
Thanks for reviewing @abeyad and @jasontedor!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Probably! I'm out the next two days. Can you do it?
…On Wed, Apr 12, 2017, 6:02 PM Boaz Leskes ***@***.***> wrote:
Thx Nik! Should we add something to our version bumping doc?
> On 12 Apr 2017, at 10:30 PM, Nik Everett ***@***.***>
wrote:
>
> Thanks for reviewing @abeyad and @jasontedor!
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub, or mute the thread.
>
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#24075 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AANLooWSG5hZRf2KBQWR1n6sPE9ksFMLks5rvUnrgaJpZM4M76lw>
.
|
I updated the guide with the steps needed for the master branch |
* master: Remove more hidden file leniency from plugins Register error listener in evil logger tests Detect using logging before configuration [DOCS] Added note about Elastic Cloud to improve 'elastic aws' SERP results. Add version constant for 5.5 (elastic#24075) Add unit tests for NestedAggregator (elastic#24054)
* master: (41 commits) Remove awaits fix from evil JNA native tests Correct handling of default and array settings Build: Switch jna dependency to an elastic version (elastic#24081) fix CategoryContextMappingTests compilation bugs testConcurrentGetAndSetOnPrimary - fix a race condition between indexing and updating value map Allow different data types for category in Context suggester (elastic#23491) Restrict build info loading to ES jar, not any jar (elastic#24049) Remove more hidden file leniency from plugins Register error listener in evil logger tests Detect using logging before configuration [DOCS] Added note about Elastic Cloud to improve 'elastic aws' SERP results. Add version constant for 5.5 (elastic#24075) Add unit tests for NestedAggregator (elastic#24054) Add more debugging information to rethrottles Tests: Use random analyzer only on string fields in Match/MultiMatchBuilderTests Cleanup outdated comments for fixing up pom dependencies (elastic#24056) S3 Repository: Eagerly load static settings (elastic#23910) Reject duplicate settings on the command line Wildcard cluster names for cross cluster search (elastic#23985) Update scripts/security docs for sandboxed world (elastic#23977) ...
Thank you Ali!
… On 13 Apr 2017, at 04:53, Ali Beyad ***@***.***> wrote:
I updated the guide with the steps needed for the master branch
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
This is required in master now that #24071 is in or else we fail during BWC testing because the 5.x branch contains 5.5 but the build thinks it should contain 5.4.