Adds tests for cardinality and filter aggregations #23826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colings86
added
review
>test
63 tasks
jpountz
requested changes
Mar 31, 2017
| } | ||
| } else { | ||
| for (long i = 0; i < runLens.size(); i++) { | ||
| values.add(runLens.get(i)); |
There was a problem hiding this comment.
I think that should be s/i/(bucket << p)+i/
| public boolean equals(long bucket, HyperLogLogPlusPlus other) { | ||
| return Objects.equals(p, other.p) && | ||
| Objects.equals(algorithm.get(bucket), other.algorithm.get(bucket)) | ||
| && |
| } | ||
| OpenBitSet other = (OpenBitSet) obj; | ||
| return Objects.equals(impl, other.impl); | ||
| } |
There was a problem hiding this comment.
It seems to me that this is not needed anymore?
| for (int i = 0; i < numDocs; i++) { | ||
| if (frequently()) { | ||
| // make sure we have more than one segment to test the merge | ||
| indexWriter.commit(); |
There was a problem hiding this comment.
you can do indexWriter.getReader().close(), which will create a segment too but not do a fsync
| import java.util.Map; | ||
|
|
||
| public class InternalCardinalityTests extends InternalAggregationTestCase<InternalCardinality> { | ||
| private static List<HyperLogLogPlusPlus> algos; |
There was a problem hiding this comment.
this variable never seems to be read?
There was a problem hiding this comment.
This is needed so we keep a reference to the HyperLogLogPlusPlus implementations we create in createTestInstance() so we can close them and release the appropriate BigArray pages after the test is complete (see the cleanup() method).
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Apr 3, 2017
* master: (137 commits) CONSOLEify the "using scripts" documentation Adds tests for cardinality and filter aggregations Add Backoff policy to azure repository Revert "Adds tests for cardinality and filter aggregations (elastic#23826)" Adds tests for cardinality and filter aggregations (elastic#23826) mute testDifferentRolesMaintainPathOnRestart Replace custom sort field with SortedSetSortField and SortedNumericSortField when possible (elastic#23827) Prevent nodes from joining if newer indices exist in the cluster (elastic#23843) Synchronized CollapseTopFieldDocs with lucenes relatives (elastic#23854) CONSOLEify analysis docs Adapted search_shards rest test to work with Perl To examine an exception in rest tests, the exception should be caught, not ignored Fixed bad YAML in rest tests Fix BootstrapForTesting blowup Ban Boolean#getBoolean Fix language in some docs CONSOLEify lang-analyzer docs Stricter parsing of remote node attribute Fix cross-cluster remote node gateway attributes FieldCapabilitiesRequest should implements Replaceable since it accepts index patterns ...
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Apr 4, 2017
* master: (146 commits) Introduce single-node discovery Await termination after shutting down executors Fix initialization issue in ElasticsearchException Fix bulk queue size in thread pool docs [DOCS] Remove line about eager loading global ordinals GceDiscoverTests - remove intitial_state_timeout SpecificMasterNodesIT shouldn't use autoMinMasterNodes testRestorePersistentSettings doesn't to mess with discovery settings testDifferentRolesMaintainPathOnRestart shouldn't use auto managing of min master nodes CONSOLEify the "using scripts" documentation Adds tests for cardinality and filter aggregations Add Backoff policy to azure repository Revert "Adds tests for cardinality and filter aggregations (elastic#23826)" Adds tests for cardinality and filter aggregations (elastic#23826) mute testDifferentRolesMaintainPathOnRestart Replace custom sort field with SortedSetSortField and SortedNumericSortField when possible (elastic#23827) Prevent nodes from joining if newer indices exist in the cluster (elastic#23843) Synchronized CollapseTopFieldDocs with lucenes relatives (elastic#23854) CONSOLEify analysis docs Adapted search_shards rest test to work with Perl ...
javanna
added a commit
to javanna/elasticsearch
that referenced
this pull request
May 23, 2017
This is a partial backport of elastic#23826
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #22278