Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests: Add unit test for SignificantLongTerms and SignificantStringTerms #23428

Merged
merged 1 commit into from
Mar 2, 2017
Merged

Tests: Add unit test for SignificantLongTerms and SignificantStringTerms #23428

merged 1 commit into from
Mar 2, 2017

Conversation

tlrx
Copy link
Member

@tlrx tlrx commented Mar 1, 2017

Relates to #22278

@tlrx tlrx added :Analytics/Aggregations Aggregations review >test Issues or PRs that are addressing/adding tests v6.0.0-alpha1 labels Mar 1, 2017
jpountz
jpountz approved these changes Mar 1, 2017
View reviewed changes
Copy link
Contributor

@jpountz jpountz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tlrx tlrx merged commit 5a668c4 into elastic:master Mar 2, 2017
@tlrx
Copy link
Member Author

tlrx commented Mar 2, 2017

Thanks @jpountz

@martijnvg martijnvg mentioned this pull request Mar 2, 2017
Closed
63 tasks
@tlrx tlrx deleted the add-significant-tests branch March 2, 2017 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpountz jpountz jpountz approved these changes

Assignees
No one assigned
Labels
:Analytics/Aggregations Aggregations >test Issues or PRs that are addressing/adding tests v6.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tlrx @jpountz