docs / test enhancement - added CONSOLE scripts for sampler aggs #22869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sampler and diversified_sampler aggs. Closes elastic#22746
markharwood
added
:Analytics/Aggregations
nik9000
approved these changes
Jan 30, 2017
| @@ -24,7 +24,6 @@ apply plugin: 'elasticsearch.docs-test' | |||
| * only remove entries from this list. When it is empty we'll remove it | |||
| * entirely and have a party! There will be cake and everything.... */ | |||
| buildRestTests.expectedUnconvertedCandidates = [ | |||
| 'reference/aggregations/bucket/diversified-sampler-aggregation.asciidoc', | |||
| @@ -28,41 +34,121 @@ Example: | |||
| "aggs": { | |||
| "keywords": { | |||
| "significant_terms": { | |||
| "field": "text" | |||
| "field": "tags", | |||
| "exclude":["kibana", "javascript"] | |||
| "sample": { | ||
| "doc_count": 1000,<1> | ||
| "doc_count": 1000<1>, |
There was a problem hiding this comment.
I think this is backwards. I should be 1000, <1> or something.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sampler and diversified_sampler aggs were missing executable CONSOLE tests.
The scores produced by the example queries are sensitive to changes in the index (e.g. numbers of deleted docs) so I have deliberately added logic to copy actual result values into the expected results we document in the example. I also wanted to provide examples to users that provide doc counts from multiple-shards but actually for test purposes wanted to use a single shard to produce deterministic results. These actual-vs-expected differences were, again, patched by test-response manipulations.
Closes #22746