S3 Repository: Deprecate specifying region #22848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The region and endpoint settings overlap, and have complicated logic for which to use. Futhermore, region is not necessary, as for most cases it is automatically figured out by the s3 client, given the bucket name, and for custom cases like a new region, the endpoint is necessary anyways. This commit adds a deprecation warning when specifying region. relates elastic#22758
This was referenced Feb 24, 2017
clintongormley
added
:Distributed Coordination/Snapshot/Restore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The region and endpoint settings overlap, and have complicated logic for
which to use. Futhermore, region is not necessary, as for most cases it
is automatically figured out by the s3 client, given the bucket name,
and for custom cases like a new region, the endpoint is necessary
anyways. This commit adds a deprecation warning when specifying region.
relates #22758