Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecation logging for lenient booleans #22696

Merged
merged 2 commits into from
Jan 19, 2017
Merged

Fix deprecation logging for lenient booleans #22696

merged 2 commits into from
Jan 19, 2017

Commits on Jan 19, 2017

  1. Fix deprecation logging for lenient booleans 

    This commit fixes an issue with deprecation logging for lenient
booleans. The underlying issue is that adding deprecation logging for
lenient booleans added a static deprecation logger to the Settings
class. However, the Settings class is initialized very early and in CLI
tools can be initialized before logging is initialized. This leads to
status logger error messages. Additionally, the deprecation logging for
a lot of the settings does not provide useful context (for example, in
the token filter factories, the deprecation logging only produces the
name of the setting, but gives no context which token filter factory it
comes from). This commit addresses both of these issues by changing the
call sites to push a deprecation logger through to the lenient boolean
parsing.
    @jasontedor
    jasontedor committed Jan 19, 2017
    Configuration menu
    Copy the full SHA
    0958752 View commit details
    Browse the repository at this point in the history

  2. Mark field in Analysis as private

    @jasontedor
    jasontedor committed Jan 19, 2017
    Configuration menu
    Copy the full SHA
    db599a8 View commit details
    Browse the repository at this point in the history