Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GET operations should not extract fields from _source. #20158

Merged

Commits on Aug 26, 2016

  1. GET operations should not extract fields from _source. elastic#20158

    This makes GET operations more consistent with `_search` operations which expect
    `(stored_)fields` to work on stored fields and source filtering to work on the
    `_source` field. This is now possible thanks to the fact that GET operations
    do not read from the translog anymore (elastic#20102) and also allows to get rid of
    `FieldMapper#isGenerated`.
    
    The `_termvectors` API (and thus more_like_this too) was relying on the fact
    that GET operations would extract fields from either stored fields or the source
    so the logic to do this that used to exist in `ShardGetService` has been moved
    to `TermVectorsService`. It would be nice that term vectors do not rely on this,
    but this does not seem to be a low hanging fruit.
    jpountz committed Aug 26, 2016
    Configuration menu
    Copy the full SHA
    3ed0da5 View commit details
    Browse the repository at this point in the history