Replace [source,json] with [source,js] in docs #18296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@clintongormley this is will fail the build for |
|
It shouldn't conflict with #18211 either.... |
|
@clintongormley can you have a look at this when you get a chance? |
|
LGTM |
The syntax highlighter only supports [source,js]. Also adds a check to the rest test generator that runs during the build that'll fail the build if it sees `[source,json]`.
nik9000
force-pushed
the
docs_js_instead_of_json
branch
from
1d448ed
to
72eb621
Compare
|
Thanks for looking @clintongormley ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The syntax highlighter only supports [source,js].
Also adds a check to the rest test generator that runs during
the build that'll fail the build if it sees
[source,json].