Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESQL: Add a random sample command #123879

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

bpintea
Copy link
Contributor

@bpintea bpintea commented Mar 3, 2025

This adds a new command, RANDOM_SAMPLE <probability> <seed>. The command is producing at output a random selection of the rows it received on the input.

It receives a probability as a first mandatory parameter, a double in the (0.0, 1.0) interval, and an optional seed, an integer value. The former determines the selectivity of the sampling, the latter its reproducibility. If no seed is provided, a random one will be used.

The command will be "pushed down" to Lucene whenever possible, using the existing RandomSamplingQuery (used by the Random sampler aggregation).
This is as usually the most efficient way to execute the command since this controls which documents will be considered for loading (or further filtering) and it will also run the selection over an entire Lucene segment.

When no "push down" is possible, an ESQL operator caches a number of input pages up to a (minimum) number of rows
(currently equal to the configured maximum result set size) and then samples this batch. Meaning that (1) all the cached pages are first collected in memory (i.e. high memory pressure) and (2), the sampling runs over a significantly reduced document ID space, compared to that of a segment's (i.e. poor sampling with low probabilities).

This adds RANDOM_SAMPLE <probability> <seed>? command.
@elasticsearchmachine
Copy link
Collaborator

Hi @bpintea, I've created a changelog YAML for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants