Adjust translog operation assertions for synthetic source #119330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhatn
force-pushed
the
relax-translog-assertion
branch
2 times, most recently
from
50240da to
8206042
Compare
dnhatn
force-pushed
the
relax-translog-assertion
branch
from
8206042 to
b521d7d
Compare
dnhatn
added
:StorageEngine/Logs
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
martijnvg
approved these changes
Dec 28, 2024
server/src/main/java/org/elasticsearch/index/engine/TranslogOperationAsserter.java
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/index/engine/TranslogOperationAsserter.java
Outdated
Show resolved
Hide resolved
henningandersen
approved these changes
Jan 2, 2025
server/src/main/java/org/elasticsearch/index/engine/TranslogOperationAsserter.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/index/engine/TranslogOperationAsserter.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/index/engine/TranslogOperationAsserter.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/index/engine/TranslogOperationAsserter.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/index/engine/TranslogOperationAsserter.java
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/index/translog/TranslogWriter.java
Outdated
Show resolved
Hide resolved
|
@martijnvg @henningandersen Thanks for reviewing! |
💔 Backport failed
You can use sqren/backport to manually backport by running |
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Jan 4, 2025
…9330) When synthetic sources are used in peer recoveries, the translog operations via peer recoveries may differ from those created through replication. This change relaxes the translog operation assertion to account for synthetic source, allowing these operations to be considered equivalent. Closes elastic#119191
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 4, 2025
…119559) When synthetic sources are used in peer recoveries, the translog operations via peer recoveries may differ from those created through replication. This change relaxes the translog operation assertion to account for synthetic source, allowing these operations to be considered equivalent. Closes #119191
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When synthetic sources are used in peer recoveries, the translog operations via peer recoveries may differ from those created through replication. This change relaxes the translog operation assertion to account for synthetic source, allowing these operations to be considered equivalent.
Closes #119191