Support flattened label field with downsampling. #118816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If flattened field is configured as non-dimension and non-metric field, then downsampling fails to execute successfully. Downsampling doesn't know how to use the flattened field or how to serialize it. This change addresses this. Closes elastic#116319
martijnvg
added
>bug
:StorageEngine/Downsampling
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
|
Hi @martijnvg, I've created a changelog YAML for you. |
kkrik-es
reviewed
Dec 17, 2024
| - '{"@timestamp": "2021-04-28T19:50:53.142Z", "metricset": "pod", "k8s": {"pod": {"name": "dog", "uid":"df3145b3-0563-4d3b-a0f7-897eb2876ea9"}, "agent": { "id": "second", "version": "2.1.9" }, "value": 25 }}' | ||
| - '{"index": {}}' | ||
| - '{"@timestamp": "2021-04-28T19:51:03.142Z", "metricset": "pod", "k8s": {"pod": {"name": "dog", "uid":"df3145b3-0563-4d3b-a0f7-897eb2876ea9"}, "agent": { "id": "second", "version": "2.1.10" }, "value": 17 }}' | ||
|
|
There was a problem hiding this comment.
Let's add a mix of flattened contents, with dotted names, null, missing entries, single value etc.
There was a problem hiding this comment.
+1 - will add more tests
…ic#118838 (will fix later) and enabled subobjects for "A flattened field as label field" test
martijnvg
changed the title
|
@kkrik-es I noticed a different issue when flattened field is defined as dimensions, see #118838. So I removed the yaml test with flattened field as dimension, and I will fix that in a followup PR. This PR will then only address flattened label fields. The fix for flattened dimensions requires more changes in downsampling and I like to keep this PR small. |
kkrik-es
reviewed
Dec 17, 2024
| assertEquals("dummy", producer.name()); | ||
| assertEquals("last_value", producer.label().name()); | ||
|
|
||
| var bytes = List.of("a\0value_a", "b\0value_b", "c\0value_c", "d\0value_d"); |
There was a problem hiding this comment.
Let's get a mix of values here as well, including null and dotted names.
kkrik-es
approved these changes
Dec 17, 2024
kkrik-es
reviewed
Dec 17, 2024
| isEmpty = false; | ||
| List<BytesRef> values = new ArrayList<>(docValuesCount); | ||
| for (int i = 0; i < docValuesCount; i++) { | ||
| values.add(new BytesRef(docValues.nextValue().toString())); |
There was a problem hiding this comment.
Is this the only change, compared to the overriden method? Can this be moved to write to avoid overriding both?
There was a problem hiding this comment.
Good point. Maybe we complete reuse the collect(...) super method and just do a bytes ref conversation in write(...) method so that FlattenedFieldSyntheticWriterHelper can use the collected values.
martijnvg
added
the
auto-backport
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Dec 18, 2024
If flattened field is configured as non-dimension and non-metric field, then downsampling fails to execute successfully. Downsampling doesn't know how to use the flattened field or how to serialize it. This change addresses this. Closes elastic#116319
This was referenced Dec 18, 2024
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Dec 18, 2024
If flattened field is configured as non-dimension and non-metric field, then downsampling fails to execute successfully. Downsampling doesn't know how to use the flattened field or how to serialize it. This change addresses this. Closes elastic#116319
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 18, 2024
If flattened field is configured as non-dimension and non-metric field, then downsampling fails to execute successfully. Downsampling doesn't know how to use the flattened field or how to serialize it. This change addresses this. Closes #116319
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 18, 2024
If flattened field is configured as non-dimension and non-metric field, then downsampling fails to execute successfully. Downsampling doesn't know how to use the flattened field or how to serialize it. This change addresses this. Closes #116319
rjernst
pushed a commit
to rjernst/elasticsearch
that referenced
this pull request
Dec 18, 2024
If flattened field is configured as non-dimension and non-metric field, then downsampling fails to execute successfully. Downsampling doesn't know how to use the flattened field or how to serialize it. This change addresses this. Closes elastic#116319
navarone-feekery
pushed a commit
to navarone-feekery/elasticsearch
that referenced
this pull request
Dec 26, 2024
If flattened field is configured as non-dimension and non-metric field, then downsampling fails to execute successfully. Downsampling doesn't know how to use the flattened field or how to serialize it. This change addresses this. Closes elastic#116319
sarog
pushed a commit
to sarog/elasticsearch
that referenced
this pull request
Jan 22, 2025
…astic#118935) If flattened field is configured as non-dimension and non-metric field, then downsampling fails to execute successfully. Downsampling doesn't know how to use the flattened field or how to serialize it. This change addresses this. Closes elastic#116319
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If flattened field is configured as non-dimension and non-metric field, then downsampling fails to execute successfully. Downsampling doesn't know how to use the flattened field or how to serialize it. This change addresses this.
Closes #116319