Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESQL: Limit size of Literal#toString #117842

Merged
merged 4 commits into from
Dec 2, 2024
Merged

ESQL: Limit size of Literal#toString #117842

merged 4 commits into from
Dec 2, 2024

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented Dec 2, 2024

This toString is rendered in task output and progress. Let's make sure it's not massive.

@nik9000 nik9000 added >bug auto-backport Automatically create backport pull requests when merged :Analytics/ES|QL AKA ESQL v9.0.0 v8.17.1 v8.18.0 labels Dec 2, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Dec 2, 2024
@elasticsearchmachine
Copy link
Collaborator

Hi @nik9000, I've created a changelog YAML for you.

Copy link
Contributor

@craigtaverner craigtaverner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nik9000 nik9000 enabled auto-merge (squash) December 2, 2024 18:41
@nik9000
Copy link
Member Author

nik9000 commented Dec 2, 2024

run elasticsearch-ci/9.0.0 / bwc-snapshots

@nik9000 nik9000 merged commit ae3d0b9 into elastic:main Dec 2, 2024
14 of 17 checks passed
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.17
8.x

nik9000 added a commit to nik9000/elasticsearch that referenced this pull request Dec 2, 2024
This `toString` is rendered in task output and progress. Let's make sure it's not massive.
nik9000 added a commit to nik9000/elasticsearch that referenced this pull request Dec 2, 2024
This `toString` is rendered in task output and progress. Let's make sure it's not massive.
elasticsearchmachine pushed a commit that referenced this pull request Dec 2, 2024
This `toString` is rendered in task output and progress. Let's make sure it's not massive.
elasticsearchmachine pushed a commit that referenced this pull request Dec 2, 2024
This `toString` is rendered in task output and progress. Let's make sure it's not massive.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL auto-backport Automatically create backport pull requests when merged >bug Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v8.17.1 v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants