Fix failing SearchQueryThenFetchAsyncActionTests #114630
Open
+18
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The version randomization has been changed recently with the unintended effect that now randomized "old" and "new" versions can be the same, and new versions can even be lower than old versions. This change corrects this by going back to the previous version randomization logic. Closes elastic#114593
cbuescher
added
>test
|
Pinging @elastic/es-search (Team:Search) |
|
@ldematte you were right with your suspicion that something was off for 8.x branch of this test in #113941 (comment), I reverted to the old randomization on the 8x branch. I think I'll also need to revisit "main" for this again. Mind to take a quick look for this test unmute & fix on 8x here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version randomization has been changed recently with the unintended effect that now randomized "old" and "new" versions can be the same, and new versions can even be lower than old versions. This change corrects this by going back to the previous version randomization logic.
Closes #114593