Further conversions to ChunkedXContentBuilder #114237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecoop
added
:Core/Infra/Core
thecoop
force-pushed
the
further-chunked-xcontent-builder
branch
from
5b0d0d0
to
21c735f
Compare
nik9000
approved these changes
Oct 7, 2024
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
matthewabbott
pushed a commit
to matthewabbott/elasticsearch
that referenced
this pull request
Oct 10, 2024
prdoyle
pushed a commit
to prdoyle/elasticsearch
that referenced
this pull request
Oct 11, 2024
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 11, 2024
* Create a fluent builder to help implement ChunkedToXContent (#112389) Rather than manually adding startObject/endObject, and having to line everything up manually, this handles the start/end for you. A few implementations are converted already. In the long run, I would like this to replace ChunkedXContentHelper. * Convert a few more implementations to ChunkedXContentBuilder (#113125) Remove the complex methods from ChunkedXContentHelper * Further conversions to ChunkedXContentBuilder (#114237) --------- Co-authored-by: Simon Cooper <simon.cooper@elastic.co>
davidkyle
pushed a commit
to davidkyle/elasticsearch
that referenced
this pull request
Oct 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aimed at removing more methods from ChunkedXContentHelper