Minimize Automaton used in APMTracer #113775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This thing was taking up 400k of heap since it wasn't minimized, turns into ~2k after minimization.
original-brownbear
added
the
:Core/Infra/Metrics
elasticsearchmachine
added
Team:Core/Infra
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
ldematte
approved these changes
Oct 2, 2024
|
Thanks Lorenzo! + yes exactly this only runs once in production :) |
|
@original-brownbear FYI this is relying on a utility that has been removed from Lucene 10 and moved to test code. It may make sense to backport this change if it makes a difference, but we are going back to not minimizing in the lucene_snapshot branch. |
gmarouli
pushed a commit
to gmarouli/elasticsearch
that referenced
this pull request
Oct 3, 2024
This thing was taking up 400k of heap since it wasn't minimized, turns into ~2k after minimization.
matthewabbott
pushed a commit
to matthewabbott/elasticsearch
that referenced
this pull request
Oct 4, 2024
This thing was taking up 400k of heap since it wasn't minimized, turns into ~2k after minimization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This thing was taking up 400k of heap since it wasn't minimized, turns into ~2k after minimization.