Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds note on reindexing existing data for semantic_text usage #113590

Merged
merged 4 commits into from
Oct 8, 2024
Merged

Adds note on reindexing existing data for semantic_text usage #113590

merged 4 commits into from
Oct 8, 2024

Conversation

kosabogi
Copy link
Contributor

@kosabogi kosabogi commented Sep 26, 2024 •
edited by szabosteve
Loading

Overview

This update adds a note to the semantic_text documentation, clarifying that reindexing is required for existing data to properly generate embeddings for semantic search.

Related Issue

#181

Preview

Tutorial: semantic search with semantic_text

@kosabogi kosabogi requested a review from ppf2 September 26, 2024 10:36
@github-actions GitHub Actions
Copy link
Contributor

Documentation preview:

@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label external-contributor Pull request authored by a developer outside the Elasticsearch team and removed Team:Docs Meta label for docs team labels Sep 26, 2024
@szabosteve szabosteve added >docs General docs changes Team:Docs Meta label for docs team labels Sep 26, 2024
@elasticsearchmachine elasticsearchmachine removed the needs:triage Requires assignment of a team area label label Sep 26, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@mark-vieira mark-vieira added auto-backport Automatically create backport pull requests when merged and removed auto-backport-and-merge labels Oct 4, 2024
@ppf2
Copy link
Member

ppf2 commented Oct 6, 2024

LGTM from the general reindexing point of view. It will be helpful to add paragraph that reminds users of web crawlers and connectors that they will have to run a full crawl or full sync after adding semantic_text to crawler or connector mappings, etc. Thx!

@kosabogi
Copy link
Contributor Author

kosabogi commented Oct 7, 2024

LGTM from the general reindexing point of view. It will be helpful to add paragraph that reminds users of web crawlers and connectors that they will have to run a full crawl or full sync after adding semantic_text to crawler or connector mappings, etc. Thx!

Thank you for the review, @ppf2!
I've added a note about full crawls and full syncs in a new commit.
Let me know if you think any adjustments are needed!

leemthompo
leemthompo reviewed Oct 7, 2024
View reviewed changes
Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a suggestion to streamline the text and keep sentences digestible :)

docs/reference/search/search-your-data/semantic-search-semantic-text.asciidoc Outdated Show resolved Hide resolved
@kosabogi @leemthompo
Update docs/reference/search/search-your-data/semantic-search-semanti…
461afbc 
…c-text.asciidoc

Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>
@kosabogi kosabogi merged commit 4af241b into elastic:main Oct 8, 2024
5 checks passed
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

The backport operation could not be completed due to the following error:

An unexpected error occurred when attempting to backport this PR.

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 113590

matthewabbott pushed a commit to matthewabbott/elasticsearch that referenced this pull request Oct 10, 2024
@kosabogi @leemthompo @matthewabbott
Adds note on reindexing existing data for semantic_text usage (elasti…
9987193 
…c#113590)

* Adds note on reindexing existing data for semantic_text usage

* Adds note about full crawl and full sync

* Style guide related fix

* Update docs/reference/search/search-your-data/semantic-search-semantic-text.asciidoc

Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>

---------

Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>
davidkyle pushed a commit to davidkyle/elasticsearch that referenced this pull request Oct 13, 2024
@kosabogi @leemthompo @davidkyle
Adds note on reindexing existing data for semantic_text usage (elasti…
f9e6369 
…c#113590)

* Adds note on reindexing existing data for semantic_text usage

* Adds note about full crawl and full sync

* Style guide related fix

* Update docs/reference/search/search-your-data/semantic-search-semantic-text.asciidoc

Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>

---------

Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leemthompo leemthompo leemthompo left review comments

@szabosteve szabosteve szabosteve approved these changes

@ppf2 ppf2 Awaiting requested review from ppf2

Assignees
No one assigned
Labels
auto-backport Automatically create backport pull requests when merged backport pending >docs General docs changes external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Docs Meta label for docs team v8.16.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kosabogi @elasticsearchmachine @ppf2 @szabosteve @leemthompo @mark-vieira