Remove legacy validation of search source in data nodes #113081
Merged
+0
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We moved the validation of incoming search requests to data nodes with elastic#105150. The legacy validation performed on the data nodes was left around for bw comp reasons, as there could still be coordinating nodes in the cluster not performing that validation. This is no longer the case in main. This commit removes the validation in favour of validation already performed while coordinating the search request. Relates to elastic#105150
javanna
added
>refactoring
:Search Foundations/Search
elasticsearchmachine
added
the
Team:Search Foundations
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
andreidan
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We moved the validation of incoming search requests to data nodes with #105150. The legacy validation performed on the data nodes was left around for bw comp reasons, as there could still be coordinating nodes in the cluster not performing that validation. This is no longer the case in main. This commit removes the validation in favour of validation already performed while coordinating the search request.
Relates to #105150