[Profiling] Use CancellableTask internally #107139
Merged
+14
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we eagerly cast the task provided to our central transport action to a CancellableTask so we can simplify cancellation checks while the action is being executed. Relates elastic#107037
danielmitterdorfer
added
>non-issue
:UniversalProfiling/Application
elasticsearchmachine
added
the
Team:obs-knowledge
|
This PR is a follow-up based on a comment from David in #107037 (comment). |
|
Pinging @elastic/obs-knowledge-team (Team:obs-knowledge) |
| licenseChecker.requireSupportedLicense(); | ||
| assert task instanceof CancellableTask; |
There was a problem hiding this comment.
using asserts here might look unusual but that is the established practice in the code base.
There was a problem hiding this comment.
++ it indicates to the reader that task is always a CancellableTask - without it a reader might think that the cast could throw an exception which is to be handled elsewhere.
DaveCTurner
approved these changes
Apr 5, 2024
| licenseChecker.requireSupportedLicense(); | ||
| assert task instanceof CancellableTask; |
There was a problem hiding this comment.
++ it indicates to the reader that task is always a CancellableTask - without it a reader might think that the cast could throw an exception which is to be handled elsewhere.
|
Thanks for quick review @DaveCTurner, much appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we eagerly cast the task provided to our central transport action to a CancellableTask so we can simplify cancellation checks while the action is being executed.
Relates #107037