Always show composed_of field for composable index templates
#105315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to e786cfa we inadvertently always added composable index templates with `composed_of: []` beacuse elastic@e786cfa#diff-5081302eb39033199deb1977d544d1cd7867212a92b8d77e0aa0ded361272b11L618-L630 created a new `ComposableIndexTemplate` from an existing one, and the `.composedOf()` field returned an empty list of no component templates were provided: https://github.com/elastic/elasticsearch/blob/89e714ee5dc60db8b4979ab6372ff767e108e9da/server/src/main/java/org/elasticsearch/cluster/metadata/ComposableIndexTemplate.java#L172-L177 This meant that before 8.12.0 we would always show `composed_of: []` for composable index templates. This commit recreates this behavior, and always displays the empty list even if no component templates are used by a composable index template. Resolves elastic#104627
dakrone
added
>bug
:Data Management/Indices APIs
|
Pinging @elastic/es-data-management (Team:Data Management) |
elasticsearchmachine
added
the
Team:Data Management
|
Hi @dakrone, I've created a changelog YAML for you. |
|
@elasticmachine update branch |
|
@elasticmachine update branch |
|
It would be nice to have this fix on 8.12.2 version... please. Thanks |
|
Will it be solved before 8.14.0? Please, solve it in Java API too... |
This was referenced Feb 15, 2024
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
Feb 15, 2024
…ic#105315) * Always show `composed_of` field for composable index templates Prior to e786cfa we inadvertently always added composable index templates with `composed_of: []` beacuse elastic@e786cfa#diff-5081302eb39033199deb1977d544d1cd7867212a92b8d77e0aa0ded361272b11L618-L630 created a new `ComposableIndexTemplate` from an existing one, and the `.composedOf()` field returned an empty list of no component templates were provided: https://github.com/elastic/elasticsearch/blob/89e714ee5dc60db8b4979ab6372ff767e108e9da/server/src/main/java/org/elasticsearch/cluster/metadata/ComposableIndexTemplate.java#L172-L177 This meant that before 8.12.0 we would always show `composed_of: []` for composable index templates. This commit recreates this behavior, and always displays the empty list even if no component templates are used by a composable index template. Resolves elastic#104627
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
Feb 15, 2024
…ic#105315) * Always show `composed_of` field for composable index templates Prior to e786cfa we inadvertently always added composable index templates with `composed_of: []` beacuse elastic@e786cfa#diff-5081302eb39033199deb1977d544d1cd7867212a92b8d77e0aa0ded361272b11L618-L630 created a new `ComposableIndexTemplate` from an existing one, and the `.composedOf()` field returned an empty list of no component templates were provided: https://github.com/elastic/elasticsearch/blob/89e714ee5dc60db8b4979ab6372ff767e108e9da/server/src/main/java/org/elasticsearch/cluster/metadata/ComposableIndexTemplate.java#L172-L177 This meant that before 8.12.0 we would always show `composed_of: []` for composable index templates. This commit recreates this behavior, and always displays the empty list even if no component templates are used by a composable index template. Resolves elastic#104627
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 15, 2024
…) (#105571) * Always show `composed_of` field for composable index templates Prior to e786cfa we inadvertently always added composable index templates with `composed_of: []` beacuse e786cfa#diff-5081302eb39033199deb1977d544d1cd7867212a92b8d77e0aa0ded361272b11L618-L630 created a new `ComposableIndexTemplate` from an existing one, and the `.composedOf()` field returned an empty list of no component templates were provided: https://github.com/elastic/elasticsearch/blob/89e714ee5dc60db8b4979ab6372ff767e108e9da/server/src/main/java/org/elasticsearch/cluster/metadata/ComposableIndexTemplate.java#L172-L177 This meant that before 8.12.0 we would always show `composed_of: []` for composable index templates. This commit recreates this behavior, and always displays the empty list even if no component templates are used by a composable index template. Resolves #104627
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 15, 2024
…) (#105572) * Always show `composed_of` field for composable index templates Prior to e786cfa we inadvertently always added composable index templates with `composed_of: []` beacuse e786cfa#diff-5081302eb39033199deb1977d544d1cd7867212a92b8d77e0aa0ded361272b11L618-L630 created a new `ComposableIndexTemplate` from an existing one, and the `.composedOf()` field returned an empty list of no component templates were provided: https://github.com/elastic/elasticsearch/blob/89e714ee5dc60db8b4979ab6372ff767e108e9da/server/src/main/java/org/elasticsearch/cluster/metadata/ComposableIndexTemplate.java#L172-L177 This meant that before 8.12.0 we would always show `composed_of: []` for composable index templates. This commit recreates this behavior, and always displays the empty list even if no component templates are used by a composable index template. Resolves #104627
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to e786cfa we inadvertently always added composable index templates with
composed_of: []beacusee786cfa#diff-5081302eb39033199deb1977d544d1cd7867212a92b8d77e0aa0ded361272b11L618-L630 created a new
ComposableIndexTemplatefrom an existing one, and the.composedOf()field returned an empty list of no component templates were provided:elasticsearch/server/src/main/java/org/elasticsearch/cluster/metadata/ComposableIndexTemplate.java
Lines 172 to 177 in 89e714e
This meant that before 8.12.0 we would always show
composed_of: []for composable index templates. This commit recreates this behavior, and always displays the empty list even if no component templates are used by a composable index template.Resolves #104627